Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"infinite loop in redraw" warning on browser zoom #17

Closed
Waddas opened this issue Jul 24, 2019 · 9 comments · Fixed by #174
Closed

"infinite loop in redraw" warning on browser zoom #17

Waddas opened this issue Jul 24, 2019 · 9 comments · Fixed by #174
Labels
bug Something isn't working released

Comments

@Waddas
Copy link

Waddas commented Jul 24, 2019

I'm using the VisJs timeline from the 'almende/vis' repo and come across an issue where if you change the zoom level (80% causes the most problems) then the redraw function gets stuck in a infinite loop. There is a repeated warning in the console 'WARNING: infinite loop in redraw?'.

There is an issue raised in the old repo: Timeline Issue: Sometimes the redraw cycle can become stuck in an infinite loop #450

I've gone through the examples for this repo and i can see is it still occurring. If the old issues are still being tracked then i apologise and feel free to close this one.

@mojoaxel mojoaxel added the bug Something isn't working label Jul 24, 2019
@mojoaxel
Copy link
Member

@Waddas Thanks for re-reporting this issue. @yotamberk is working (see #5) on the next big release that will fix a lot of issues. We'll see if this problem still exists after the merge.

@javdome
Copy link
Contributor

javdome commented Jul 25, 2019

I think it will no fix the problem... the same issue was recently opened in Timeline-plus yotamberk/timeline-plus#175

You can also see more information there.

@molkemon
Copy link

molkemon commented Aug 7, 2019

DISREGARD THIS I AM DUMB.
I did not have the css file loaded.... well that's two hours I'm never gonna get back, but in the rare event someone may be even remotely as dumb as me, that's your solution....

I am experiencing this issue aswell (with the soon to be merged timeline-plus). I don't have browser zoom on, what I am trying to do is load the timline inside a div within a DataTables Cell.

It flat out doesn't work, after getting item data via ajax the error message repeats itself a few times and then it just outputs "0" as text. No graph at all.

@yotamberk
Copy link
Member

yotamberk commented Aug 11, 2019

Can you supply a simple jsbin so I can try to fix this with a reproducible example?

@Waddas
Copy link
Author

Waddas commented Aug 14, 2019

@yotamberk Not sure what json you would want to see. If you use the basic example https://visjs.github.io/vis-timeline/examples/timeline/basicUsage.html and reduce the browser zoom to 80%. then resize the browser, you should see the warning in the console.

@mojoaxel mojoaxel changed the title Redraw cycle can become stuck in an infinite loop "infinite loop in redraw" warning on browser zoom Aug 14, 2019
@mojoaxel
Copy link
Member

@Waddas Thanks. I can confirm this.

@mojoaxel
Copy link
Member

Wow, this is an old bug! see almende/vis#450 for more history!

@frankdevryerold
Copy link

Is there any update on this issue?

@vis-bot
Copy link
Collaborator

vis-bot commented Nov 18, 2019

🎉 This issue has been resolved in version 6.2.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working released
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants