Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: issue #17 #174

Merged
merged 2 commits into from
Nov 18, 2019
Merged

fix: issue #17 #174

merged 2 commits into from
Nov 18, 2019

Conversation

yotamberk
Copy link
Member

Basing on almende/vis#450 and yotamberk/timeline-plus#175, I've finally got down to the problem with zooming in browser causing infinite redraws bug.
fixes #17

Copy link
Member

@Thomaash Thomaash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work without issues.

Copy link
Member

@mojoaxel mojoaxel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So it was a rounding issue 😖

Thanks for fixing this!
LGTM

@yotamberk yotamberk merged commit cf7bc8f into master Nov 18, 2019
@yotamberk yotamberk deleted the zoom-browser-bug branch November 18, 2019 19:06
@vis-bot
Copy link
Collaborator

vis-bot commented Nov 18, 2019

🎉 This PR is included in version 6.2.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

@tynvlad
Copy link

tynvlad commented Nov 27, 2019

I think bug was actual for in latest version of lib. I reproduced it in chrome 78.0.3904.108 using code from yotamberk/timeline-plus#175 (by changing library). :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"infinite loop in redraw" warning on browser zoom
5 participants