-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: MEEG data #27
WIP: MEEG data #27
Conversation
How do I see the data that I've added? I click the "login" button, but a window pops up and immediately disappears. I assume I need to actually add a user to the system somewhere...? Also, in the code I have a lot of |
Since Kevin has left our team, this repo has been largely unmaintained. I will add line comments to your code regarding the |
@property | ||
def nims_group_id(self): | ||
# XXX | ||
return 'group_id' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SciTran data are organized in a group, project, session, acquisition hierarchy. A group is approximately equivalent to a university research lab. The group "owns" the project. If the provided group does not exist, data will end up in the "unknown" group. By default, live.sh
provisions a "scitran" group.
I provided my gmail address during the configure step, but when I click "login" a window quickly appears and disappears. Not sure what the deal is with that. I assumed the CI errors were due to |
@property | ||
def nims_session_id(self): | ||
# XXX | ||
return 'session_id' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a unique ID for the session that contains this acquisition. A session is roughly equivalent to a DICOM study. For DICOM we use the study instance UID.
Actually, we're going to run into the same problem here as we did in https://github.com/scitran/scitran/pull/57, namely that I need to install |
@property | ||
def nims_session_subject(self): | ||
# XXX | ||
return 'subj_code' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
An identifier for the subject. For DICOM, we get this from the patient ID.
@property | ||
def nims_acquisition_id(self): | ||
# XXX | ||
return 'nims_acquisition_id' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a unique ID for this acquisition. An acquisition is roughly equivalent to a DICOM series. For DICOM we use the series instance UID.
That is probably the Google login window that comes and goes. Please try using Chrome with the default popup blocking settings. |
'field': 'subj_dob', | ||
'title': 'Date of Birth', | ||
'type': 'string', | ||
'format': 'date', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gsfr how / where do I populate these fields? I looked at DICOM, and at least to start, I know I can fill these fields based on what's in the MEG files.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ahhh, based on looking at other modules, I think I need to set the e.g. .subj_firstname
attribute of the Reader
class.
That's what I'm on (Chrome w/defaults) I think. I actually see the window open up and close, so it's not getting blocked. And If I have the webpage open, and kill the server, then the window opens with a URL and a not-found error as you'd expect -- but it at least indicates that, when the server is running, it is visiting the appropriate URL and auto-closes really quickly. Is that normal behavior? Even after that there is no indication that I am logged in, the "Login" link is still there, and clicking it still makes the window pop up and disappear. |
FYI Travis build time dropped from 4 minutes to 1:42 with the use of the |
Sounds like you have CI figured out. I think the rules are pretty loose in this repo, given the lack of a maintainer. I really don't know what's going on with the login window. Have you looked at Chrome's console? @rentzso Could you please upgrade SDM so that a fresh install via |
@gsfr done with this commit: https://github.com/scitran/sdm/commit/fdbaba40bc8b95f4b38ba3fb844c989c30a13eeb |
Closing for PR into |
Currently in the state that it will store the data in
persistent/data/
when used with scitran/reaper#12 and https://github.com/scitran/scitran/pull/57.Closes #4.