Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: MEEG data #27

Closed
wants to merge 6 commits into from
Closed

WIP: MEEG data #27

wants to merge 6 commits into from

Conversation

larsoner
Copy link
Contributor

Currently in the state that it will store the data in persistent/data/ when used with scitran/reaper#12 and https://github.com/scitran/scitran/pull/57.

Closes #4.

@larsoner
Copy link
Contributor Author

How do I see the data that I've added? I click the "login" button, but a window pops up and immediately disappears. I assume I need to actually add a user to the system somewhere...?

Also, in the code I have a lot of XXXs, which indicate that I don't know how to set those variables appropriately. Are the meanings of the nims_ parameters documented somewhere? I was hoping they'd be documented under class Reader but there isn't anything there yet. I'm happy to add some docstrings to all those properties if someone can enumerate them, or we can video-chat about them. I am curious what I should do when a property isn't defined, though. I am also not sure how to populate the entries for the session_properties that are created.

@gsfr
Copy link
Contributor

gsfr commented Aug 19, 2015

Since Kevin has left our team, this repo has been largely unmaintained. I will add line comments to your code regarding the nims_ properties.
When you first run live.sh configure, it should ask you about bootstrapping a user. You need to provide a Google OAuth capable email address. With that, you will be able to log in.
Also, please fix the CI errors.

@property
def nims_group_id(self):
# XXX
return 'group_id'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SciTran data are organized in a group, project, session, acquisition hierarchy. A group is approximately equivalent to a university research lab. The group "owns" the project. If the provided group does not exist, data will end up in the "unknown" group. By default, live.sh provisions a "scitran" group.

@larsoner
Copy link
Contributor Author

I provided my gmail address during the configure step, but when I click "login" a window quickly appears and disappears. Not sure what the deal is with that.

I assumed the CI errors were due to mne not being installed in scitran (https://github.com/scitran/scitran/pull/57), but I suppose I also need to add an installer to the Travis script here, as well. I'll do that now.

@property
def nims_session_id(self):
# XXX
return 'session_id'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a unique ID for the session that contains this acquisition. A session is roughly equivalent to a DICOM study. For DICOM we use the study instance UID.

@larsoner
Copy link
Contributor Author

Actually, we're going to run into the same problem here as we did in https://github.com/scitran/scitran/pull/57, namely that I need to install scipy and it's going to be too slow here. I can change Travis to use Anaconda, or let it use the system packages and install numpy and scipy from there. Will either of those options work here? In theory using the system packages should make the build quite a bit faster.

@property
def nims_session_subject(self):
# XXX
return 'subj_code'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An identifier for the subject. For DICOM, we get this from the patient ID.

@property
def nims_acquisition_id(self):
# XXX
return 'nims_acquisition_id'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a unique ID for this acquisition. An acquisition is roughly equivalent to a DICOM series. For DICOM we use the series instance UID.

@gsfr
Copy link
Contributor

gsfr commented Aug 19, 2015

That is probably the Google login window that comes and goes. Please try using Chrome with the default popup blocking settings.

'field': 'subj_dob',
'title': 'Date of Birth',
'type': 'string',
'format': 'date',
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gsfr how / where do I populate these fields? I looked at DICOM, and at least to start, I know I can fill these fields based on what's in the MEG files.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ahhh, based on looking at other modules, I think I need to set the e.g. .subj_firstname attribute of the Reader class.

@larsoner
Copy link
Contributor Author

That's what I'm on (Chrome w/defaults) I think. I actually see the window open up and close, so it's not getting blocked. And If I have the webpage open, and kill the server, then the window opens with a URL and a not-found error as you'd expect -- but it at least indicates that, when the server is running, it is visiting the appropriate URL and auto-closes really quickly. Is that normal behavior? Even after that there is no indication that I am logged in, the "Login" link is still there, and clicking it still makes the window pop up and disappear.

@larsoner
Copy link
Contributor Author

FYI Travis build time dropped from 4 minutes to 1:42 with the use of the scikit-image wheels to install dependencies, despite the fact that I added two (scipy and mne)

@gsfr
Copy link
Contributor

gsfr commented Aug 19, 2015

Sounds like you have CI figured out. I think the rules are pretty loose in this repo, given the lack of a maintainer.

I really don't know what's going on with the login window. Have you looked at Chrome's console?
Come to think of it, you might have to edit the BASE_URL in sdm/app/custom/config.js. It is still hardcoded and does not use the newish scitran config system.

@rentzso Could you please upgrade SDM so that a fresh install via live.sh works out of the box?

@rentzso
Copy link
Contributor

rentzso commented Aug 19, 2015

@gsfr gsfr mentioned this pull request Aug 21, 2015
@larsoner
Copy link
Contributor Author

Closing for PR into master instead of zip_file

@larsoner larsoner closed this Aug 21, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants