fix(client): hmr on web workers #18554
Open
+305
−167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
userquin
changed the title
|
Looks like Windows cannot copy this folder:
NOTE: using node 20.10.0 LTS => unicode fixed in 20.12.0 => testing with Node 22.6.0 LTS and working EDIT: running e2e tests with Node 22.6.0 LTS
|
userquin
commented
Nov 1, 2024
| await untilUpdated( | ||
| () => page.textContent('.simple-worker-url'), | ||
| 'Hello from simple worker!', | ||
| true, |
There was a problem hiding this comment.
uhmm, I need to review this
There was a problem hiding this comment.
looks like we don't test build in CI and so we can just remove the true param here, maybe used in some other test?
There was a problem hiding this comment.
the flag used only with isBuild, it doesn't matter if we pass it or not
|
Also checked HMR overlay:
|
ArnaudBarre
reviewed
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There is a todo in L360 in the client module, should we clear the console?
fixes #5396
/cc @bluwy from your comment here #10262 (comment)
Cannot run
vitest run -c vitest.config.e2e.ts(nr test-serve) on my local Windows laptop (I have developer mode enabled and repo cloned usinggit clone -c core.symlinks=true ...):