feat: support module-sync condition when loading config if enabled
#18650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sapphi-red
added
the
p2-nice-to-have
sapphi-red
commented
Nov 13, 2024
Comment on lines
-24
to
-25
| "types": "./dist/node/index.d.ts", | ||
| "default": "./dist/node/index.js" |
There was a problem hiding this comment.
TypeScript can infer the position in these kind of cases.
bluwy
previously approved these changes
Nov 25, 2024
bluwy
approved these changes
Nov 25, 2024
Sec32fun32
approved these changes
Nov 25, 2024
Sec32fun32
approved these changes
Nov 25, 2024
sapphi-red
deleted the
feat/support-module-sync-condition-when-enabled
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
With this PR, users can now import variables not exposed in CJS build by
require. It requires the users to enablerequire(esm)by setting--experimental-require-moduleor using Node 23+.related #18649