handle keyspace with trailing-slash, no shards

Signed-off-by: Tim Vaillancourt <[email protected]>

go/vt/vtorc/logic/tablet_discovery.go

@@ -59,14 +59,19 @@ var (
 // time because the list never changes.
 func parseClustersToWatch() {
 	for _, ks := range clustersToWatch {
-		if strings.Contains(ks, "/") {
+		if strings.Contains(ks, "/") && !strings.HasSuffix(ks, "/") {
 			// Validate keyspace/shard parses.
 			if _, _, err := topoproto.ParseKeyspaceShard(ks); err != nil {
 				log.Errorf("Could not parse keyspace/shard %q: %+v", ks, err)
 				continue
 			}
 			shardsToWatch[ks] = true
 		} else {
+			// Remove trailing slash, if exists
+			if strings.HasSuffix(ks, "/") {
+				ks = strings.TrimSuffix(ks, "/")
+			}
+
 			// Assume this is a keyspace and find all shards in keyspace.
 			ctx, cancel := context.WithTimeout(context.Background(), topo.RemoteOperationTimeout)
 			defer cancel()

go/vt/vtorc/logic/tablet_discovery_test.go

@@ -132,12 +132,10 @@ func TestParseClustersToWatch(t *testing.T) {
 			expected: map[string]bool{},
 		},
 		{
-			in:       []string{"test/"},
-			expected: map[string]bool{"test/": true},
-		},
-		{
-			in:       []string{"test/-"},
-			expected: map[string]bool{"test/-": true},
+			in: []string{"test/-"},
+			expected: map[string]bool{
+				"test/-": true,
+			},
 		},
 		{
 			in: []string{"test/-", "test2/-80", "test2/80-"},
@@ -154,6 +152,13 @@ func TestParseClustersToWatch(t *testing.T) {
 				topoproto.KeyspaceShardString(keyspace, shard): true,
 			},
 		},
+		{
+			// confirm shards fetch from topo when keyspace has trailing-slash
+			in: []string{keyspace + "/"},
+			expected: map[string]bool{
+				topoproto.KeyspaceShardString(keyspace, shard): true,
+			},
+		},
 	}
 
 	for _, testCase := range testCases {