Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for more queries #14369

Merged
merged 9 commits into from
Nov 1, 2023
Merged

Add support for more queries #14369

merged 9 commits into from
Nov 1, 2023

Conversation

systay
Copy link
Collaborator

@systay systay commented Oct 26, 2023 •
edited
Loading

Description

This PR removes limitations that were no longer necessary after the planner refactoring that happened this year.

In particular, we can allow most queries to run inside derived tables. This was blocking important queries from the TypeORM framework to work on Vitess.

Related Issue(s)

Fixes #9214

Checklist

  • "Backport to:" labels have been added if this change should be back-ported
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on the CI
  • Documentation was added or is not required

@vitess-bot
Copy link
Contributor

vitess-bot bot commented Oct 26, 2023

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Oct 26, 2023
@github-actions github-actions bot added this to the v19.0.0 milestone Oct 26, 2023
@systay systay added Type: Enhancement Logical improvement (somewhere between a bug and feature) Component: Query Serving and removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request labels Oct 26, 2023
@systay systay marked this pull request as ready for review October 26, 2023 08:28
@systay
test: wait for schema tracking
d00c684 
Signed-off-by: Andres Taylor <[email protected]>
harshit-gangal
harshit-gangal reviewed Oct 26, 2023
View reviewed changes
go/test/endtoend/vtgate/queries/informationschema/informationschema_test.go Outdated
rc.TABLE_NAME = kcu.TABLE_NAME
AND
rc.CONSTRAINT_NAME = kcu.CONSTRAINT_NAME`
utils.AssertMatches(t, mcmp.VtConn, query, "[]")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

better to modify the DDL such that the query results in some rows.

GuptaManan100
GuptaManan100 approved these changes Oct 27, 2023
View reviewed changes
Copy link
Member

@GuptaManan100 GuptaManan100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@systay systay force-pushed the typeorm branch 2 times, most recently from 5be20c3 to e4b1d04 Compare November 1, 2023 12:26
@systay systay force-pushed the typeorm branch 2 times, most recently from 1bd9da1 to 181c461 Compare November 1, 2023 14:24
@systay systay merged commit b26a2d1 into vitessio:main Nov 1, 2023
115 checks passed
@systay systay deleted the typeorm branch November 1, 2023 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuptaManan100 GuptaManan100 GuptaManan100 approved these changes

@harshit-gangal harshit-gangal harshit-gangal approved these changes

@frouioui frouioui Awaiting requested review from frouioui frouioui is a code owner

@arthurschreiber arthurschreiber Awaiting requested review from arthurschreiber arthurschreiber is a code owner

Assignees
No one assigned
Labels
Component: Query Serving Type: Enhancement Logical improvement (somewhere between a bug and feature)
Projects
None yet
Milestone
v19.0.0
Development

Successfully merging this pull request may close these issues.

typeorm: add support for information schema query coming from framework
3 participants
@systay @harshit-gangal @GuptaManan100