-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
evalengine: Proper support for bit literals #14374
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vicent Marti <[email protected]>
Signed-off-by: Vicent Marti <[email protected]>
Signed-off-by: Vicent Marti <[email protected]>
vmg
requested review from
harshit-gangal,
systay,
frouioui,
GuptaManan100 and
mattlord
as code owners
October 26, 2023 10:56
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
vitess-bot
bot
added
NeedsDescriptionUpdate
The description is not clear or comprehensive enough, and needs work
NeedsIssue
A linked issue is missing for this Pull Request
NeedsWebsiteDocsUpdate
What it says
labels
Oct 26, 2023
vmg
added
Type: Internal Cleanup
Component: Evalengine
changes to the evaluation engine
and removed
NeedsDescriptionUpdate
The description is not clear or comprehensive enough, and needs work
NeedsWebsiteDocsUpdate
What it says
NeedsIssue
A linked issue is missing for this Pull Request
labels
Oct 26, 2023
dbussink
reviewed
Oct 26, 2023
systay
approved these changes
Oct 26, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Signed-off-by: Vicent Marti <[email protected]>
dbussink
approved these changes
Oct 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We weren't handling bit literals properly, neither in the
sqlparser
, nor theevalengine
.The first problem we had was in the parser: the bind var extractor was normalizing all Bit literals as hex, which is not correct. There's an actual difference between hex and bits in MySQL: in a numerical context, hex is handled as an unsigned integer but bits are handled as a signed integer. So the parser must maintain the difference between them.
I normalized the parser to generate
BitNum
literals for all bit literals. Unlike for hex, whereHexVal
(x'aabbccdd'
) andHexNum
(0xaabbccdd
) are handled differently during evaluation, both kinds of bit literals0b0101
andb'0101'
are handled identically, so we don't need to expose both literal types. We now normalize everything to the earlier "numeric" form with the0b
prefix because it's easier to handle.With these changes to the parser in place, we can update the
evalengine
to take into account the new types during evaluation.cc @dbussink @systay
Related Issue(s)
Checklist
Deployment Notes