Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

evalengine: Proper support for bit literals #14374

Merged
merged 4 commits into from
Oct 26, 2023

Conversation

vmg
Copy link
Collaborator

@vmg vmg commented Oct 26, 2023

Description

We weren't handling bit literals properly, neither in the sqlparser, nor the evalengine.

The first problem we had was in the parser: the bind var extractor was normalizing all Bit literals as hex, which is not correct. There's an actual difference between hex and bits in MySQL: in a numerical context, hex is handled as an unsigned integer but bits are handled as a signed integer. So the parser must maintain the difference between them.

I normalized the parser to generate BitNum literals for all bit literals. Unlike for hex, where HexVal (x'aabbccdd') and HexNum (0xaabbccdd) are handled differently during evaluation, both kinds of bit literals 0b0101 and b'0101' are handled identically, so we don't need to expose both literal types. We now normalize everything to the earlier "numeric" form with the 0b prefix because it's easier to handle.

With these changes to the parser in place, we can update the evalengine to take into account the new types during evaluation.

cc @dbussink @systay

Related Issue(s)

Checklist

  • "Backport to:" labels have been added if this change should be back-ported
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on the CI
  • Documentation was added or is not required

Deployment Notes

@vitess-bot
Copy link
Contributor

vitess-bot bot commented Oct 26, 2023

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Oct 26, 2023
@vmg vmg added Type: Internal Cleanup Component: Evalengine changes to the evaluation engine and removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request labels Oct 26, 2023
@github-actions github-actions bot added this to the v19.0.0 milestone Oct 26, 2023
go/mysql/collations/local.go Outdated Show resolved Hide resolved
go/vt/sqlparser/ast_format.go Show resolved Hide resolved
go/vt/vtgate/evalengine/fn_time.go Show resolved Hide resolved
Copy link
Collaborator

@systay systay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@vmg vmg merged commit bc8df35 into vitessio:main Oct 26, 2023
115 checks passed
@vmg vmg deleted the vmg/evalengine-bits branch October 26, 2023 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Evalengine changes to the evaluation engine Type: Internal Cleanup
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants