Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Miscellaneous typo fixes to comments #14472

Merged
merged 5 commits into from
Nov 25, 2023
Merged

Miscellaneous typo fixes to comments #14472

merged 5 commits into from
Nov 25, 2023

Conversation

rohit-nayak-ps
Copy link
Contributor

@rohit-nayak-ps rohit-nayak-ps commented Nov 6, 2023 •
edited
Loading

Description

Just scratching an itch. Found a few typos while working on recent PRs in different parts of the code base and thought it was worth doing one pass to fix some typos. Ran Code/Analyze Code/Run Inspection By Name/Typo in GoLand for a few packages, just for comments, and fixed the obvious ones.

Related Issue(s)

Checklist

  • "Backport to:" labels have been added if this change should be back-ported
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on the CI
  • Documentation was added or is not required

Deployment Notes

@rohit-nayak-ps rohit-nayak-ps added Type: Internal Cleanup Component: General Changes throughout the code base labels Nov 6, 2023
@vitess-bot vitess-bot
Copy link
Contributor

vitess-bot bot commented Nov 6, 2023

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Nov 6, 2023
@github-actions github-actions bot added this to the v19.0.0 milestone Nov 6, 2023
@rohit-nayak-ps rohit-nayak-ps removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request labels Nov 6, 2023
@rohit-nayak-ps rohit-nayak-ps added Component: General Changes throughout the code base and removed Component: General Changes throughout the code base labels Nov 23, 2023
@rohit-nayak-ps rohit-nayak-ps marked this pull request as ready for review November 24, 2023 09:09
shlomi-noach
shlomi-noach approved these changes Nov 24, 2023
View reviewed changes
Copy link
Contributor

@shlomi-noach shlomi-noach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My code definitely holds a major percentage of changes here. Not my proudest moment.

@frouioui frouioui merged commit faf9815 into vitessio:main Nov 25, 2023
115 checks passed
@frouioui frouioui deleted the rohit/spell1 branch November 25, 2023 00:34
ejortegau pushed a commit to slackhq/vitess that referenced this pull request Dec 13, 2023
@rohit-nayak-ps @ejortegau
Miscellaneous typo fixes to comments (vitessio#14472)
bc286c8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frouioui frouioui frouioui approved these changes

@shlomi-noach shlomi-noach shlomi-noach approved these changes

@deepthi deepthi Awaiting requested review from deepthi deepthi is a code owner

@mattlord mattlord Awaiting requested review from mattlord mattlord is a code owner

@derekperkins derekperkins Awaiting requested review from derekperkins derekperkins is a code owner

@harshit-gangal harshit-gangal Awaiting requested review from harshit-gangal harshit-gangal is a code owner

@systay systay Awaiting requested review from systay systay is a code owner

@GuptaManan100 GuptaManan100 Awaiting requested review from GuptaManan100 GuptaManan100 is a code owner

@ajm188 ajm188 Awaiting requested review from ajm188 ajm188 is a code owner

@arthurschreiber arthurschreiber Awaiting requested review from arthurschreiber arthurschreiber is a code owner

@notfelineit notfelineit Awaiting requested review from notfelineit notfelineit is a code owner

Assignees
No one assigned
Labels
Component: General Changes throughout the code base Type: Internal Cleanup
Projects
None yet
Milestone
v19.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@rohit-nayak-ps @shlomi-noach @frouioui