Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Foreign_key_checks a Vitess Aware variable #14484

Merged
merged 29 commits into from
Nov 20, 2023

Conversation

GuptaManan100
Copy link
Member

@GuptaManan100 GuptaManan100 commented Nov 7, 2023

Description

This PR makes FOREIGN_KEY_CHECKS as a Vitess aware variable. Planning gets affected because of this variable, so introducing Vitess managed foreign keys prompted this change. We now keep track of this variable in the session. This PR also adds the capability to the sqlparser to parse and read the optimiser hint comments to find the value of FOREIGN_KEY_CHECKS if specified as part of a SET_VAR optimiser hint.

Once this information has been processed, we store it in the vcursor and use this for planning. The plan hash has also been changed to take into account the foreign key checks state because the plans produced in different states are different and need to be cached separately.

Plan tests have been added and fuzzer changes have been made to test out this new functionality.

Related Issue(s)

Checklist

  • "Backport to:" labels have been added if this change should be back-ported
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on the CI
  • Documentation was added or is not required

Deployment Notes

Copy link
Contributor

vitess-bot bot commented Nov 7, 2023

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Nov 7, 2023
@GuptaManan100 GuptaManan100 added Type: Enhancement Logical improvement (somewhere between a bug and feature) Component: Query Serving and removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request labels Nov 7, 2023
@github-actions github-actions bot added this to the v19.0.0 milestone Nov 7, 2023
@GuptaManan100 GuptaManan100 marked this pull request as ready for review November 9, 2023 09:53
@harshit-gangal harshit-gangal merged commit 543e761 into vitessio:main Nov 20, 2023
115 checks passed
@harshit-gangal harshit-gangal deleted the fk-checks-vitess-aware branch November 20, 2023 08:35
@vmg
Copy link
Collaborator

vmg commented Nov 20, 2023

Good change Manan! Ended up being much smaller than I expected ✨

@GuptaManan100
Copy link
Member Author

Thank-you very much! 💕

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Query Serving Type: Enhancement Logical improvement (somewhere between a bug and feature)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants