-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multi Target Delete Support #15294
Multi Target Delete Support #15294
Conversation
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
Signed-off-by: Harshit Gangal <[email protected]>
Signed-off-by: Harshit Gangal <[email protected]>
3886f7a
to
15305ad
Compare
Signed-off-by: Harshit Gangal <[email protected]>
15305ad
to
a91c5db
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #15294 +/- ##
==========================================
- Coverage 67.41% 65.43% -1.99%
==========================================
Files 1560 1561 +1
Lines 192752 193632 +880
==========================================
- Hits 129952 126703 -3249
- Misses 62800 66929 +4129 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Harshit Gangal <[email protected]>
Signed-off-by: Harshit Gangal <[email protected]>
Signed-off-by: Harshit Gangal <[email protected]>
Signed-off-by: Harshit Gangal <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple of questions, rest lgtm
Signed-off-by: Harshit Gangal <[email protected]>
Description
This PR is an enhancement on earlier PR to add support for multi-target delete.
Example:
delete u, m from user u, music m on u.col = m.col
The SQL here deletes rows from two tables using the join condition.
Related Issue(s)
Checklist
Deployment Notes