Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-19.0] VReplication: Make Target Sequence Initialization More Robust (#15289) #15308

Merged
merged 1 commit into from
Feb 20, 2024

Conversation

vitess-bot[bot]
Copy link
Contributor

@vitess-bot vitess-bot bot commented Feb 20, 2024

Description

This is a backport of #15289

Copy link
Contributor Author

vitess-bot bot commented Feb 20, 2024

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@github-actions github-actions bot added this to the v19.0.0 milestone Feb 20, 2024
Copy link

codecov bot commented Feb 20, 2024

Codecov Report

Attention: 22 lines in your changes are missing coverage. Please review.

Comparison is base (e518430) 67.31% compared to head (936bc35) 67.38%.
Report is 1 commits behind head on release-19.0.

Files Patch % Lines
go/vt/vtctl/workflow/traffic_switcher.go 0.00% 9 Missing ⚠️
go/vt/vtctl/workflow/server.go 0.00% 7 Missing ⚠️
go/vt/wrangler/traffic_switcher.go 62.50% 6 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##           release-19.0   #15308      +/-   ##
================================================
+ Coverage         67.31%   67.38%   +0.07%     
================================================
  Files              1559     1559              
  Lines            192077   192103      +26     
================================================
+ Hits             129291   129458     +167     
+ Misses            62786    62645     -141     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dbussink dbussink merged commit aa3977d into release-19.0 Feb 20, 2024
203 of 204 checks passed
@dbussink dbussink deleted the backport-15289-to-release-19.0 branch February 20, 2024 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant