Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

delete TestActionAndTimeout #15322

Merged
merged 1 commit into from
Feb 22, 2024
Merged

delete TestActionAndTimeout #15322

merged 1 commit into from
Feb 22, 2024

Conversation

ajm188
Copy link
Contributor

@ajm188 ajm188 commented Feb 21, 2024 •
edited
Loading

Description

Deletes a test that never passed for the right reason.

Related Issue(s)

Fixes #15321

Checklist

  • "Backport to:" labels have been added if this change should be back-ported to release branches
  • If this change is to be back-ported to previous releases, a justification is included in the PR description
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on CI?
  • Documentation was added or is not required

Deployment Notes

@ajm188 ajm188 requested a review from deepthi as a code owner February 21, 2024 13:28
@vitess-bot vitess-bot
Copy link
Contributor

vitess-bot bot commented Feb 21, 2024

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Feb 21, 2024
@ajm188 ajm188 requested review from mattlord and frouioui February 21, 2024 13:28
@ajm188 ajm188 removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels Feb 21, 2024
@github-actions github-actions bot added this to the v20.0.0 milestone Feb 21, 2024
@dbussink
Copy link
Contributor

Deletes a test that never passed.

How was it not failing CI in this case? Or do we not even run it?

dbussink
dbussink approved these changes Feb 21, 2024
View reviewed changes
Copy link
Contributor

@dbussink dbussink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah wait, the issue further describes that.

@ajm188
Copy link
Contributor Author

ajm188 commented Feb 21, 2024

yeah realizing without the issue that was unclear, so i updated the PR description

deepthi
deepthi approved these changes Feb 22, 2024
View reviewed changes
Copy link
Member

@deepthi deepthi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

delete TestActionAndTimeout
d55eac3 
Signed-off-by: Andrew Mason <[email protected]>
@ajm188 ajm188 force-pushed the andrew/delete-actiontimeout-test branch from 8a73674 to d55eac3 Compare February 22, 2024 13:46
@ajm188 ajm188 merged commit 89bc131 into vitessio:main Feb 22, 2024
100 checks passed
@ajm188 ajm188 deleted the andrew/delete-actiontimeout-test branch February 22, 2024 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deepthi deepthi deepthi approved these changes

@dbussink dbussink dbussink approved these changes

@mattlord mattlord Awaiting requested review from mattlord

@frouioui frouioui Awaiting requested review from frouioui

Assignees
No one assigned
Labels
Component: Build/CI Component: Cluster management Type: Internal Cleanup
Projects
Technical debt / Cleanup
Status: Done
Milestone
v20.0.0
Development

Successfully merging this pull request may close these issues.

Bug Report: e2e/tabletmanager TestActionAndTimeout passes errantly
3 participants
@ajm188 @dbussink @deepthi