Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-19.0] Column alias expanding on ORDER BY (#15302) #15329

Merged
merged 3 commits into from
Feb 22, 2024

Conversation

vitess-bot[bot]
Copy link
Contributor

@vitess-bot vitess-bot bot commented Feb 22, 2024

Description

This is a backport of #15302

@vitess-bot vitess-bot bot added Backport This is a backport Component: Query Serving Merge Conflict Skip CI Skip CI actions from running Type: Bug labels Feb 22, 2024
Copy link
Contributor Author

vitess-bot bot commented Feb 22, 2024

Hello @systay, there are conflicts in this backport.

Please address them in order to merge this Pull Request. You can execute the snippet below to reset your branch and resolve the conflict manually.

Make sure you replace origin by the name of the vitessio/vitess remote

git fetch --all
gh pr checkout 15329 -R vitessio/vitess
git reset --hard origin/release-19.0
git cherry-pick -m 1 c536bb7b26603931f6f2adac0065cf2a0c210869

Copy link
Contributor Author

vitess-bot bot commented Feb 22, 2024

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

Co-authored-by: Harshit Gangal <[email protected]>
Co-authored-by: Manan Gupta <[email protected]>
Signed-off-by: Andres Taylor <[email protected]>
@systay systay force-pushed the backport-15302-to-release-19.0 branch from 302a918 to bea2b59 Compare February 22, 2024 08:21
@systay systay removed Skip CI Skip CI actions from running Merge Conflict labels Feb 22, 2024
@systay systay marked this pull request as ready for review February 22, 2024 08:21
Signed-off-by: Andres Taylor <[email protected]>
Copy link

codecov bot commented Feb 22, 2024

Codecov Report

Attention: 21 lines in your changes are missing coverage. Please review.

Comparison is base (e8283bf) 67.37% compared to head (fd4e2ee) 67.39%.

Files Patch % Lines
go/vt/vtgate/semantics/early_rewriter.go 91.71% 15 Missing ⚠️
go/vt/vtgate/semantics/errors.go 33.33% 6 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##           release-19.0   #15329      +/-   ##
================================================
+ Coverage         67.37%   67.39%   +0.02%     
================================================
  Files              1559     1559              
  Lines            192107   192257     +150     
================================================
+ Hits             129427   129573     +146     
- Misses            62680    62684       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Andres Taylor <[email protected]>
@dbussink dbussink merged commit 979014c into release-19.0 Feb 22, 2024
199 checks passed
@dbussink dbussink deleted the backport-15302-to-release-19.0 branch February 22, 2024 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants