Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix type coercion between the sides of an UNION #15340

Merged
merged 6 commits into from
Mar 8, 2024

orderby: add test

ee0f9b4
Select commit
Loading
Failed to load commit list.
Merged

Fix type coercion between the sides of an UNION #15340

orderby: add test
ee0f9b4
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Mar 8, 2024 in 0s

65.72% (-0.01%) compared to 6c73053, passed because coverage increased by +0.01% when compared to adjusted base (65.70%)

View this Pull Request on Codecov

65.72% (-0.01%) compared to 6c73053, passed because coverage increased by +0.01% when compared to adjusted base (65.70%)

Details

Codecov Report

Attention: Patch coverage is 90.50633% with 15 lines in your changes are missing coverage. Please review.

Project coverage is 65.72%. Comparing base (6c73053) to head (ee0f9b4).
Report is 2 commits behind head on main.

Files Patch % Lines
go/vt/vtgate/engine/concatenate.go 93.75% 3 Missing ⚠️
go/vt/vtgate/engine/distinct.go 86.36% 3 Missing ⚠️
go/vt/vtgate/evalengine/eval_numeric.go 66.66% 2 Missing ⚠️
...o/vt/vtgate/planbuilder/operators/union_merging.go 71.42% 2 Missing ⚠️
go/vt/vtgate/semantics/table_collector.go 77.77% 2 Missing ⚠️
go/vt/vtgate/evalengine/api_type_aggregation.go 95.23% 1 Missing ⚠️
go/vt/vtgate/evalengine/compiler.go 95.00% 1 Missing ⚠️
go/vt/vtgate/evalengine/eval.go 95.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #15340      +/-   ##
==========================================
- Coverage   65.72%   65.72%   -0.01%     
==========================================
  Files        1563     1562       -1     
  Lines      194027   193952      -75     
==========================================
- Hits       127529   127468      -61     
+ Misses      66498    66484      -14

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov