Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: change FuncExpr to use Exprs instead of SelectExprs #15368

Merged
merged 2 commits into from
Feb 27, 2024

Conversation

systay
Copy link
Collaborator

@systay systay commented Feb 27, 2024

Description

A pure refactoring. Functions (FuncExpr)were accepting the interface SelectExpr, because we used this for count(*). That need is no longer there, since we have separate parsing and AST struct for count(*) now.

This PR just changes FuncExpr to use pure expressions and not aliased expressions.

Related Issue(s)

Checklist

  • "Backport to:" labels have been added if this change should be back-ported to release branches
  • If this change is to be back-ported to previous releases, a justification is included in the PR description
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on CI?
  • Documentation was added or is not required

Copy link
Contributor

vitess-bot bot commented Feb 27, 2024

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Feb 27, 2024
@github-actions github-actions bot added this to the v20.0.0 milestone Feb 27, 2024
@systay systay added Type: Enhancement Logical improvement (somewhere between a bug and feature) Component: Query Serving and removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels Feb 27, 2024
@systay systay marked this pull request as ready for review February 27, 2024 08:18
Copy link
Member

@GuptaManan100 GuptaManan100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it

Signed-off-by: Andres Taylor <[email protected]>
Copy link

codecov bot commented Feb 27, 2024

Codecov Report

Attention: Patch coverage is 63.15789% with 14 lines in your changes are missing coverage. Please review.

Project coverage is 65.42%. Comparing base (696fe0e) to head (8616a7a).
Report is 58 commits behind head on main.

Files Patch % Lines
go/vt/vttablet/tabletmanager/vdiff/table_differ.go 0.00% 4 Missing ⚠️
go/vt/wrangler/materializer.go 0.00% 4 Missing ⚠️
go/vt/wrangler/vdiff.go 0.00% 4 Missing ⚠️
go/vt/vtgate/simplifier/expression_simplifier.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #15368      +/-   ##
==========================================
- Coverage   67.41%   65.42%   -1.99%     
==========================================
  Files        1560     1561       +1     
  Lines      192752   193584     +832     
==========================================
- Hits       129952   126662    -3290     
- Misses      62800    66922    +4122     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@systay systay merged commit dab2af2 into vitessio:main Feb 27, 2024
102 checks passed
@systay systay deleted the ast-refactor branch February 27, 2024 11:14
@deepthi
Copy link
Member

deepthi commented Feb 27, 2024

Note for reviewers - refactors should be marked as Internal Cleanup so that we don't need to require an Issue. Enhancements are required to have an issue associated with them.

@deepthi deepthi added Type: Internal Cleanup and removed Type: Enhancement Logical improvement (somewhere between a bug and feature) labels Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants