-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: change FuncExpr to use Exprs instead of SelectExprs #15368
Conversation
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
Signed-off-by: Andres Taylor <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love it
Signed-off-by: Andres Taylor <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #15368 +/- ##
==========================================
- Coverage 67.41% 65.42% -1.99%
==========================================
Files 1560 1561 +1
Lines 192752 193584 +832
==========================================
- Hits 129952 126662 -3290
- Misses 62800 66922 +4122 ☔ View full report in Codecov by Sentry. |
Note for reviewers - refactors should be marked as |
Description
A pure refactoring. Functions (
FuncExpr
)were accepting the interfaceSelectExpr
, because we used this forcount(*)
. That need is no longer there, since we have separate parsing and AST struct forcount(*)
now.This PR just changes
FuncExpr
to use pure expressions and not aliased expressions.Related Issue(s)
Checklist