-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-19.0] Bugfix: GROUP BY/HAVING alias resolution (#15344) #15377
Merged
GuptaManan100
merged 2 commits into
vitessio:release-19.0
from
planetscale:backport-of-15344-to-19
Feb 29, 2024
Merged
[release-19.0] Bugfix: GROUP BY/HAVING alias resolution (#15344) #15377
GuptaManan100
merged 2 commits into
vitessio:release-19.0
from
planetscale:backport-of-15344-to-19
Feb 29, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
systay
requested review from
harshit-gangal,
frouioui,
GuptaManan100 and
arthurschreiber
as code owners
February 28, 2024 10:40
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
Signed-off-by: Andres Taylor <[email protected]>
systay
force-pushed
the
backport-of-15344-to-19
branch
from
February 29, 2024 08:29
938bfed
to
f2d010a
Compare
harshit-gangal
approved these changes
Feb 29, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release-19.0 #15377 +/- ##
================================================
- Coverage 67.42% 67.41% -0.01%
================================================
Files 1560 1560
Lines 192390 192581 +191
================================================
+ Hits 129718 129833 +115
- Misses 62672 62748 +76 ☔ View full report in Codecov by Sentry. |
GuptaManan100
approved these changes
Feb 29, 2024
Signed-off-by: Manan Gupta <[email protected]>
GuptaManan100
merged commit Feb 29, 2024
977b585
into
vitessio:release-19.0
101 of 102 checks passed
frouioui
changed the title
This is a backport of vitessio#15344
[release-19.0] Bugfix: GROUP BY/HAVING alias resolution (#15344)
Mar 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a backport of #15344