Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-18.0] Bugfix: GROUP BY/HAVING alias resolution (#15344) #15381

Merged
merged 4 commits into from
Feb 29, 2024
Merged

[release-18.0] Bugfix: GROUP BY/HAVING alias resolution (#15344) #15381

merged 4 commits into from
Feb 29, 2024

Conversation

vitess-bot[bot]
Copy link
Contributor

@vitess-bot vitess-bot bot commented Feb 28, 2024

Description

This is a backport of #15344

@vitess-bot vitess-bot bot added Backport This is a backport Component: Query Serving Merge Conflict Skip CI Skip CI actions from running Type: Bug labels Feb 28, 2024
@vitess-bot vitess-bot
Copy link
Contributor Author

vitess-bot bot commented Feb 28, 2024

Hello @systay, there are conflicts in this backport.

Please address them in order to merge this Pull Request. You can execute the snippet below to reset your branch and resolve the conflict manually.

Make sure you replace origin by the name of the vitessio/vitess remote

git fetch --all
gh pr checkout 15381 -R vitessio/vitess
git reset --hard origin/release-18.0
git cherry-pick -m 1 15f58869c45e47875f26e95291bcc656a686a269

@vitess-bot vitess-bot
Copy link
Contributor Author

vitess-bot bot commented Feb 28, 2024

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@github-actions github-actions bot added this to the v18.0.3 milestone Feb 28, 2024
@systay systay force-pushed the backport-15344-to-release-18.0 branch from 49d991c to 01d460d Compare February 29, 2024 08:42
@systay systay removed Skip CI Skip CI actions from running Merge Conflict labels Feb 29, 2024
@systay
empty commit to trigger ci
5305270 
Signed-off-by: Andres Taylor <[email protected]>
@systay systay marked this pull request as ready for review February 29, 2024 08:42
@deepthi deepthi merged commit bf05f5f into release-18.0 Feb 29, 2024
203 checks passed
@deepthi deepthi deleted the backport-15344-to-release-18.0 branch February 29, 2024 15:56
JiekerTime pushed a commit to JiekerTime/vitess that referenced this pull request Mar 8, 2024
merge master0306 (vitessio#205)
0221e5f 
* fix test cases

* Merge branch 'master' into split-table-merge-master0306

* fix ci test

* Bugfix: GROUP BY/HAVING alias resolution (vitessio#15344) (vitessio#15381

* add params for proxy support ddl operations

* merge origin

* fix client_found_row (vitessio#203)

* merge origin to a2c986c

* fix client found rows

* Use GetTabletsByCell in healthcheck

* delete start params:track_schema_versions.

* auto delete logs from three days ago

* 解决跨cell获取节点失败和SQL权限没有正确拦截的问题

* merge origin 3a35dd

* 支持MySQL8.0编译... (vitessio#185)

* 修改show vitess_shards|vitess_tables和 show variables (vitessio#175)

* fix binaryhash

* fix: container restart ，programs restart failed

* add start params

* merge origin with laster pr:f39ada

* fix vttablet startup

* fix openEuler dockerfile

* merge origin bugfix

* fix master ci

* Bugfix: fix pinned table for splitclone (vitessio#141)
JiekerTime pushed a commit to JiekerTime/vitess that referenced this pull request Mar 8, 2024
merge master0307 (vitessio#207)
1ad4983 
* Merge branch 'master' into split-table-merge-master0306

* 修复agent容器无法跨容器恢复MySQL数据的问题

* fix test cases

* fix ci test

* Bugfix: GROUP BY/HAVING alias resolution (vitessio#15344) (vitessio#15381

* add params for proxy support ddl operations

* merge origin

* fix client_found_row (vitessio#203)

* merge origin to a2c986c

* fix client found rows

* Use GetTabletsByCell in healthcheck

* delete start params:track_schema_versions.

* auto delete logs from three days ago

* 解决跨cell获取节点失败和SQL权限没有正确拦截的问题

* merge origin 3a35dd

* 支持MySQL8.0编译... (vitessio#185)

* 修改show vitess_shards|vitess_tables和 show variables (vitessio#175)

* fix binaryhash

* fix: container restart ，programs restart failed

* add start params

* merge origin with laster pr:f39ada

* fix vttablet startup

* fix openEuler dockerfile

* merge origin bugfix

* fix master ci

* Bugfix: fix pinned table for splitclone (vitessio#141)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuptaManan100 GuptaManan100 GuptaManan100 approved these changes

@deepthi deepthi deepthi approved these changes

@arthurschreiber arthurschreiber Awaiting requested review from arthurschreiber arthurschreiber is a code owner

@systay systay Awaiting requested review from systay systay is a code owner

@harshit-gangal harshit-gangal Awaiting requested review from harshit-gangal harshit-gangal is a code owner

@frouioui frouioui Awaiting requested review from frouioui frouioui is a code owner

Assignees
No one assigned
Labels
Backport This is a backport Component: Query Serving Type: Bug
Projects
None yet
Milestone
v18.0.3
Development

Successfully merging this pull request may close these issues.
3 participants
@deepthi @GuptaManan100 @systay