Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing Column aliases in outer join queries #15384

Merged
merged 8 commits into from
Mar 5, 2024

test: update test expectations

7d0dff2
Select commit
Loading
Failed to load commit list.
Merged

Fixing Column aliases in outer join queries #15384

test: update test expectations
7d0dff2
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Mar 4, 2024 in 0s

65.46% (-1.96%) compared to 696fe0e

View this Pull Request on Codecov

65.46% (-1.96%) compared to 696fe0e

Details

Codecov Report

Attention: Patch coverage is 89.28571% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 65.46%. Comparing base (696fe0e) to head (7d0dff2).
Report is 70 commits behind head on main.

❗ Current head 7d0dff2 differs from pull request most recent head 604503e. Consider uploading reports for the commit 604503e to get more accurate results

Files Patch % Lines
go/vt/vtgate/engine/simple_projection.go 84.61% 2 Missing ⚠️
go/vt/vtgate/planbuilder/operators/projection.go 90.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #15384      +/-   ##
==========================================
- Coverage   67.41%   65.46%   -1.96%     
==========================================
  Files        1560     1562       +2     
  Lines      192752   193926    +1174     
==========================================
- Hits       129952   126955    -2997     
- Misses      62800    66971    +4171     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.