-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[vtctldclient] Add GetShardReplication #15389
Merged
ajm188
merged 5 commits into
vitessio:main
from
planetscale:andrew/vtctldclient-get-shard-replication
Feb 29, 2024
Merged
[vtctldclient] Add GetShardReplication #15389
ajm188
merged 5 commits into
vitessio:main
from
planetscale:andrew/vtctldclient-get-shard-replication
Feb 29, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrew Mason <[email protected]>
Signed-off-by: Andrew Mason <[email protected]>
Signed-off-by: Andrew Mason <[email protected]>
Signed-off-by: Andrew Mason <[email protected]>
Signed-off-by: Andrew Mason <[email protected]>
ajm188
added
Type: Feature
Component: Cluster management
Backport to: release-19.0
Needs to be back ported to release-19.0
labels
Feb 29, 2024
ajm188
requested review from
deepthi,
harshit-gangal,
mattlord,
notfelineit and
rohit-nayak-ps
as code owners
February 29, 2024 14:15
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
vitess-bot
bot
added
NeedsBackportReason
If backport labels have been applied to a PR, a justification is required
NeedsDescriptionUpdate
The description is not clear or comprehensive enough, and needs work
NeedsIssue
A linked issue is missing for this Pull Request
NeedsWebsiteDocsUpdate
What it says
labels
Feb 29, 2024
5 tasks
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #15389 +/- ##
==========================================
+ Coverage 65.44% 65.46% +0.01%
==========================================
Files 1562 1562
Lines 193863 193911 +48
==========================================
+ Hits 126880 126938 +58
+ Misses 66983 66973 -10 ☔ View full report in Codecov by Sentry. |
notfelineit
approved these changes
Feb 29, 2024
rohit-nayak-ps
approved these changes
Feb 29, 2024
ajm188
removed
NeedsDescriptionUpdate
The description is not clear or comprehensive enough, and needs work
NeedsWebsiteDocsUpdate
What it says
NeedsIssue
A linked issue is missing for this Pull Request
NeedsBackportReason
If backport labels have been applied to a PR, a justification is required
labels
Feb 29, 2024
vitess-bot
pushed a commit
that referenced
this pull request
Feb 29, 2024
Signed-off-by: Andrew Mason <[email protected]>
frouioui
pushed a commit
that referenced
this pull request
Mar 4, 2024
Signed-off-by: Andrew Mason <[email protected]> Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Backport to: release-19.0
Needs to be back ported to release-19.0
Component: Cluster management
Type: Feature
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Its omission was discovered in #15297.
I'd like to backport this to 19.0 while the release window is still open.
Demo
Related Issue(s)
Closes #15386
Checklist
Deployment Notes