Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vtctldclient] Add GetShardReplication #15389

Merged

Conversation

ajm188
Copy link
Contributor

@ajm188 ajm188 commented Feb 29, 2024

Description

Its omission was discovered in #15297.

I'd like to backport this to 19.0 while the release window is still open.

Demo

vtctldclient --server :15999 GetShardReplication commerce/0
{
  "shard_replication_by_cell": {
    "zone1": {
      "nodes": [
        {
          "tablet_alias": {
            "cell": "zone1",
            "uid": 100
          }
        },
        {
          "tablet_alias": {
            "cell": "zone1",
            "uid": 101
          }
        },
        {
          "tablet_alias": {
            "cell": "zone1",
            "uid": 102
          }
        }
      ]
    }
  }
}

Related Issue(s)

Closes #15386

Checklist

  • "Backport to:" labels have been added if this change should be back-ported to release branches
  • If this change is to be back-ported to previous releases, a justification is included in the PR description
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on CI?
  • Documentation was added or is not required

Deployment Notes

Andrew Mason added 5 commits February 29, 2024 08:50
Signed-off-by: Andrew Mason <[email protected]>
Signed-off-by: Andrew Mason <[email protected]>
Signed-off-by: Andrew Mason <[email protected]>
Signed-off-by: Andrew Mason <[email protected]>
Signed-off-by: Andrew Mason <[email protected]>
Copy link
Contributor

vitess-bot bot commented Feb 29, 2024

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Feb 29, 2024
@github-actions github-actions bot added this to the v20.0.0 milestone Feb 29, 2024
Copy link

codecov bot commented Feb 29, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 24 lines in your changes are missing coverage. Please review.

Project coverage is 65.46%. Comparing base (15f5886) to head (477bfd1).

Files Patch % Lines
go/cmd/vtctldclient/command/shards.go 5.26% 18 Missing ⚠️
go/vt/vtctl/grpcvtctldclient/client_gen.go 0.00% 4 Missing ⚠️
go/vt/vtctl/localvtctldclient/client_gen.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #15389      +/-   ##
==========================================
+ Coverage   65.44%   65.46%   +0.01%     
==========================================
  Files        1562     1562              
  Lines      193863   193911      +48     
==========================================
+ Hits       126880   126938      +58     
+ Misses      66983    66973      -10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ajm188 ajm188 removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels Feb 29, 2024
@ajm188 ajm188 merged commit 45ae25e into vitessio:main Feb 29, 2024
110 of 118 checks passed
@ajm188 ajm188 deleted the andrew/vtctldclient-get-shard-replication branch February 29, 2024 15:54
vitess-bot pushed a commit that referenced this pull request Feb 29, 2024
frouioui pushed a commit that referenced this pull request Mar 4, 2024
Signed-off-by: Andrew Mason <[email protected]>
Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Add GetShardReplication to vtctldclient
3 participants