Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Multi Target Update Support #15402

Merged
merged 9 commits into from
Mar 11, 2024

Conversation

harshit-gangal
Copy link
Member

@harshit-gangal harshit-gangal commented Mar 5, 2024

Description

This PR is an enhancement on earlier PR to add support for multi-target update.

Example: update user u join m on u.col = m.col set u.foo = 32, m.bar = 23 where u.id = 2
The SQL here updates columns from two tables using the join condition.

Related Issue(s)

Checklist

  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on CI?
  • Documentation was added or is not required

Deployment Notes

@harshit-gangal harshit-gangal added Type: Feature Component: Query Serving release notes (needs details) This PR needs to be listed in the release notes in a dedicated section (deprecation notice, etc...) labels Mar 5, 2024
Copy link
Contributor

vitess-bot bot commented Mar 5, 2024

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Mar 5, 2024
@github-actions github-actions bot added this to the v20.0.0 milestone Mar 5, 2024
@harshit-gangal harshit-gangal removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels Mar 5, 2024
Copy link

codecov bot commented Mar 5, 2024

Codecov Report

Attention: Patch coverage is 92.67016% with 14 lines in your changes are missing coverage. Please review.

Project coverage is 65.64%. Comparing base (983a3c8) to head (20b3b5f).
Report is 3 commits behind head on main.

Files Patch % Lines
go/vt/vtgate/planbuilder/operators/update.go 94.61% 7 Missing ⚠️
go/vt/vtgate/semantics/semantic_state.go 77.77% 4 Missing ⚠️
go/vt/vtgate/planbuilder/operators/delete.go 89.47% 2 Missing ⚠️
go/vt/vtgate/planbuilder/operators/dml_planning.go 87.50% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #15402      +/-   ##
==========================================
- Coverage   65.72%   65.64%   -0.08%     
==========================================
  Files        1562     1562              
  Lines      193952   194318     +366     
==========================================
+ Hits       127474   127567      +93     
- Misses      66478    66751     +273     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@harshit-gangal harshit-gangal changed the title Feature: Multi Target Delete Support Feature: Multi Target Update Support Mar 5, 2024
@harshit-gangal harshit-gangal removed release notes (needs details) This PR needs to be listed in the release notes in a dedicated section (deprecation notice, etc...) NeedsIssue A linked issue is missing for this Pull Request labels Mar 6, 2024
@harshit-gangal harshit-gangal marked this pull request as ready for review March 6, 2024 09:19
go/vt/sqlparser/ast_funcs.go Outdated Show resolved Hide resolved
Signed-off-by: Harshit Gangal <[email protected]>
@harshit-gangal harshit-gangal merged commit 4c70c7e into vitessio:main Mar 11, 2024
102 checks passed
@harshit-gangal harshit-gangal deleted the upd-multi-target branch March 11, 2024 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants