-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Multi Target Update Support #15402
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harshit-gangal
added
Type: Feature
Component: Query Serving
release notes (needs details)
This PR needs to be listed in the release notes in a dedicated section (deprecation notice, etc...)
labels
Mar 5, 2024
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
vitess-bot
bot
added
NeedsBackportReason
If backport labels have been applied to a PR, a justification is required
NeedsDescriptionUpdate
The description is not clear or comprehensive enough, and needs work
NeedsIssue
A linked issue is missing for this Pull Request
NeedsWebsiteDocsUpdate
What it says
labels
Mar 5, 2024
harshit-gangal
removed
NeedsDescriptionUpdate
The description is not clear or comprehensive enough, and needs work
NeedsWebsiteDocsUpdate
What it says
NeedsBackportReason
If backport labels have been applied to a PR, a justification is required
labels
Mar 5, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #15402 +/- ##
==========================================
- Coverage 65.72% 65.64% -0.08%
==========================================
Files 1562 1562
Lines 193952 194318 +366
==========================================
+ Hits 127474 127567 +93
- Misses 66478 66751 +273 ☔ View full report in Codecov by Sentry. |
harshit-gangal
changed the title
Feature: Multi Target Delete Support
Feature: Multi Target Update Support
Mar 5, 2024
harshit-gangal
removed
release notes (needs details)
This PR needs to be listed in the release notes in a dedicated section (deprecation notice, etc...)
NeedsIssue
A linked issue is missing for this Pull Request
labels
Mar 6, 2024
harshit-gangal
force-pushed
the
upd-multi-target
branch
from
March 6, 2024 09:18
35a21d9
to
b104cc2
Compare
harshit-gangal
requested review from
systay,
frouioui,
GuptaManan100,
arthurschreiber and
deepthi
as code owners
March 6, 2024 09:19
Signed-off-by: Harshit Gangal <[email protected]>
Signed-off-by: Harshit Gangal <[email protected]>
Signed-off-by: Harshit Gangal <[email protected]>
Signed-off-by: Harshit Gangal <[email protected]>
harshit-gangal
force-pushed
the
upd-multi-target
branch
from
March 6, 2024 11:27
347033d
to
1e3d3ee
Compare
frouioui
reviewed
Mar 6, 2024
frouioui
reviewed
Mar 6, 2024
frouioui
reviewed
Mar 6, 2024
frouioui
approved these changes
Mar 6, 2024
systay
reviewed
Mar 8, 2024
systay
reviewed
Mar 8, 2024
harshit-gangal
force-pushed
the
upd-multi-target
branch
from
March 8, 2024 09:23
d257c1a
to
0fdbd03
Compare
…dded e2e test case Signed-off-by: Harshit Gangal <[email protected]>
harshit-gangal
force-pushed
the
upd-multi-target
branch
from
March 8, 2024 09:24
0fdbd03
to
09192be
Compare
…leSet information for target tables Signed-off-by: Harshit Gangal <[email protected]>
Signed-off-by: Harshit Gangal <[email protected]>
Signed-off-by: Harshit Gangal <[email protected]>
systay
reviewed
Mar 8, 2024
systay
reviewed
Mar 8, 2024
systay
reviewed
Mar 11, 2024
systay
approved these changes
Mar 11, 2024
Signed-off-by: Harshit Gangal <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is an enhancement on earlier PR to add support for multi-target update.
Example:
update user u join m on u.col = m.col set u.foo = 32, m.bar = 23 where u.id = 2
The SQL here updates columns from two tables using the join condition.
Related Issue(s)
Checklist
Deployment Notes