Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure to use latest golangci-lint #15413

Merged
merged 1 commit into from
Mar 6, 2024
Merged

Ensure to use latest golangci-lint #15413

merged 1 commit into from
Mar 6, 2024

Conversation

dbussink
Copy link
Contributor

@dbussink dbussink commented Mar 6, 2024 •
edited
Loading

Install the latest golangci-lint and fix up configuration.

Marked for backport as v19 is also on Go 1.22 and needs the latest too and exportloopref is not needed there either.

Checklist

  • "Backport to:" labels have been added if this change should be back-ported to release branches
  • If this change is to be back-ported to previous releases, a justification is included in the PR description
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on CI?
  • Documentation was added or is not required

@dbussink
Ensure to use latest golangci-lint
51aae80 
Signed-off-by: Dirkjan Bussink <[email protected]>
@dbussink dbussink added the Backport to: release-19.0 Needs to be back ported to release-19.0 label Mar 6, 2024
@vitess-bot vitess-bot
Copy link
Contributor

vitess-bot bot commented Mar 6, 2024

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Mar 6, 2024
@dbussink dbussink added Component: Build/CI Type: CI/Build and removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels Mar 6, 2024
@github-actions github-actions bot added this to the v20.0.0 milestone Mar 6, 2024
@rohit-nayak-ps rohit-nayak-ps merged commit a65b90d into vitessio:main Mar 6, 2024
113 checks passed
@rohit-nayak-ps rohit-nayak-ps deleted the dbussink/use-latest-golangci-lint branch March 6, 2024 09:19
vitess-bot pushed a commit that referenced this pull request Mar 6, 2024
@vitess-bot
Ensure to use latest golangci-lint (#15413)
46e6ed2 
Signed-off-by: Dirkjan Bussink <[email protected]>
@vitess-bot vitess-bot bot mentioned this pull request Mar 6, 2024
Merged
frouioui added a commit that referenced this pull request Mar 6, 2024
@vitess-bot @frouioui
[release-19.0] Ensure to use latest golangci-lint (#15413) (#15414)
ea97f6c 
Signed-off-by: Dirkjan Bussink <[email protected]>
Signed-off-by: Florent Poinsard <[email protected]>
Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>
Co-authored-by: Florent Poinsard <[email protected]>
@deepthi deepthi mentioned this pull request Mar 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rohit-nayak-ps rohit-nayak-ps rohit-nayak-ps approved these changes

@systay systay systay approved these changes

@deepthi deepthi Awaiting requested review from deepthi deepthi is a code owner

@frouioui frouioui Awaiting requested review from frouioui frouioui is a code owner

@mattlord mattlord Awaiting requested review from mattlord mattlord is a code owner

Assignees
No one assigned
Labels
Backport to: release-19.0 Needs to be back ported to release-19.0 Component: Build/CI Type: CI/Build
Projects
None yet
Milestone
v20.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@dbussink @systay @rohit-nayak-ps