-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
planbuilder: Cleanup unused logic #15415
Merged
systay
merged 1 commit into
vitessio:main
from
planetscale:dbussink/cleanup-unused-logic
Mar 6, 2024
Merged
planbuilder: Cleanup unused logic #15415
systay
merged 1 commit into
vitessio:main
from
planetscale:dbussink/cleanup-unused-logic
Mar 6, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `getVindexInformation` call was returning alternative vindexes, but that was never used by callers. `getUpdateVindexInformation` returned it, but it's callers also never used it. This means we can remove this, as nothing depends on it. Signed-off-by: Dirkjan Bussink <[email protected]>
dbussink
requested review from
harshit-gangal,
systay,
frouioui,
GuptaManan100 and
arthurschreiber
as code owners
March 6, 2024 10:43
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
vitess-bot
bot
added
NeedsBackportReason
If backport labels have been applied to a PR, a justification is required
NeedsDescriptionUpdate
The description is not clear or comprehensive enough, and needs work
NeedsIssue
A linked issue is missing for this Pull Request
NeedsWebsiteDocsUpdate
What it says
labels
Mar 6, 2024
dbussink
removed
NeedsDescriptionUpdate
The description is not clear or comprehensive enough, and needs work
NeedsWebsiteDocsUpdate
What it says
NeedsIssue
A linked issue is missing for this Pull Request
NeedsBackportReason
If backport labels have been applied to a PR, a justification is required
labels
Mar 6, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #15415 +/- ##
==========================================
- Coverage 67.41% 65.65% -1.77%
==========================================
Files 1560 1562 +2
Lines 192752 194005 +1253
==========================================
- Hits 129952 127375 -2577
- Misses 62800 66630 +3830 ☔ View full report in Codecov by Sentry. |
ajm188
approved these changes
Mar 6, 2024
systay
approved these changes
Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
getVindexInformation
call was returning alternative vindexes, but that was never used by callers.getUpdateVindexInformation
returned it, but it's callers also never used it.This means we can remove this, as nothing depends on it.
Checklist