Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DDL strategy flag --unsafe-allow-foreign-keys implies setting FOREIGN_KEY_CHECKS=0 #15432

Merged
merged 4 commits into from
Mar 11, 2024

ignore foreign key checks on cleanup

3c3c4a0
Select commit
Loading
Failed to load commit list.
Merged

DDL strategy flag --unsafe-allow-foreign-keys implies setting FOREIGN_KEY_CHECKS=0 #15432

ignore foreign key checks on cleanup
3c3c4a0
Select commit
Loading
Failed to load commit list.
Codecov / codecov/patch succeeded Mar 10, 2024 in 0s

18.75% of diff hit (target 65.72%)

View this Pull Request on Codecov

18.75% of diff hit (target 65.72%)

Annotations

Check warning on line 493 in go/vt/schemamanager/tablet_executor.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

go/vt/schemamanager/tablet_executor.go#L493 

Added line #L493 was not covered by tests

Check warning on line 498 in go/vt/schemamanager/tablet_executor.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

go/vt/schemamanager/tablet_executor.go#L497-L498 

Added lines #L497 - L498 were not covered by tests

Check warning on line 500 in go/vt/schemamanager/tablet_executor.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

go/vt/schemamanager/tablet_executor.go#L500 

Added line #L500 was not covered by tests

Check warning on line 649 in go/vt/vttablet/onlineddl/executor.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

go/vt/vttablet/onlineddl/executor.go#L649 

Added line #L649 was not covered by tests

Check warning on line 656 in go/vt/vttablet/onlineddl/executor.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

go/vt/vttablet/onlineddl/executor.go#L655-L656 

Added lines #L655 - L656 were not covered by tests

Check warning on line 660 in go/vt/vttablet/onlineddl/executor.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

go/vt/vttablet/onlineddl/executor.go#L658-L660 

Added lines #L658 - L660 were not covered by tests

Check warning on line 662 in go/vt/vttablet/onlineddl/executor.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

go/vt/vttablet/onlineddl/executor.go#L662 

Added line #L662 was not covered by tests

Check warning on line 1493 in go/vt/vttablet/onlineddl/executor.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

go/vt/vttablet/onlineddl/executor.go#L1493 

Added line #L1493 was not covered by tests

Check warning on line 3013 in go/vt/vttablet/onlineddl/executor.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

go/vt/vttablet/onlineddl/executor.go#L3013 

Added line #L3013 was not covered by tests
View more details on Codecov