oops #15542
Closed
oops #15542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Manan Gupta <[email protected]>
…o#12273) * Revert default MySQL 80 version * upgrade mysql80 default to 8.0.30 * Add release notes regarding MySQL upgrade path in the vitess-operator * Remove unwanted upgrade path step --------- Signed-off-by: Florent Poinsard <[email protected]>
* Release notes for 16.0.0-rc1 Signed-off-by: Manan Gupta <[email protected]> * Release commit for 16.0.0-rc1 Signed-off-by: Manan Gupta <[email protected]> --------- Signed-off-by: Manan Gupta <[email protected]>
Signed-off-by: Manan Gupta <[email protected]>
Signed-off-by: Manan Gupta <[email protected]>
* Download mariadb from vitess-resources * Use proper mariadb version increment in tests * Use 10.10.3 instead of LTS --------- Signed-off-by: Florent Poinsard <[email protected]>
Signed-off-by: Manan Gupta <[email protected]>
Signed-off-by: Manan Gupta <[email protected]> Co-authored-by: Manan Gupta <[email protected]>
…sio#12311) * fix: aggregation coming from right hand side of left join check for null Signed-off-by: Harshit Gangal <[email protected]> * test: added a sum test Signed-off-by: Harshit Gangal <[email protected]> * addressed review comments Signed-off-by: Harshit Gangal <[email protected]> --------- Signed-off-by: Harshit Gangal <[email protected]> Co-authored-by: Harshit Gangal <[email protected]>
…2281) (vitessio#12308) Signed-off-by: Harshit Gangal <[email protected]>
Signed-off-by: Harshit Gangal <[email protected]> Co-authored-by: Harshit Gangal <[email protected]>
Signed-off-by: Harshit Gangal <[email protected]>
…vitessio#12278) * Add lib functions to wait for shard states * Fixup region example too * Address minor review comments * Remove extraneous line change * Refactor to remove duplicated files/code Also address shellcheck warnings. * Fix tests that run in CI * Use more robust location detection * Fix backup tests * Exit on shard healthy failure * Remove unused dups and adjust client_test and Dockerfiles --------- Signed-off-by: Matt Lord <[email protected]>
Signed-off-by: Andres Taylor <[email protected]>
Signed-off-by: Andres Taylor <[email protected]> Co-authored-by: Andres Taylor <[email protected]>
* feat: proto changes to add new rpc Signed-off-by: Harshit Gangal <[email protected]> * feat: vttablet changes in queryservice to implement the new rpc Signed-off-by: Harshit Gangal <[email protected]> * added test on tabletserver Signed-off-by: Harshit Gangal <[email protected]> * feat: use the new schema rpc in vtgate to get updated view definition Signed-off-by: Harshit Gangal <[email protected]> * remove error from getschemaresponse and change the enum name Signed-off-by: Harshit Gangal <[email protected]> * updated proto files for vtadmin Signed-off-by: Harshit Gangal <[email protected]> * fix e2e test Signed-off-by: Harshit Gangal <[email protected]> --------- Signed-off-by: Harshit Gangal <[email protected]>
…essio#12320) (vitessio#12362) * TableFilter: fix excluded RE listing Signed-off-by: Shlomi Noach <[email protected]> * extract GCTableNameExpression Signed-off-by: Shlomi Noach <[email protected]> * VReplication: exclude GC tables when reading schema Signed-off-by: Shlomi Noach <[email protected]> * wrap schema analyzis errors for better tracability Signed-off-by: Shlomi Noach <[email protected]> --------- Signed-off-by: Shlomi Noach <[email protected]> Co-authored-by: Shlomi Noach <[email protected]>
…vitessio#12381) * Fix SHOW VSCHEMA TABLES tests using v17 vtgate Signed-off-by: Florent Poinsard <[email protected]> * Fix tests expectations Signed-off-by: Florent Poinsard <[email protected]> --------- Signed-off-by: Florent Poinsard <[email protected]>
Bumps [golang.org/x/net](https://github.com/golang/net) from 0.5.0 to 0.7.0. - [Release notes](https://github.com/golang/net/releases) - [Commits](golang/net@v0.5.0...v0.7.0) --- updated-dependencies: - dependency-name: golang.org/x/net dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
) (vitessio#12406) * Allow zero (in) date when setting up internal _vt schema * modify test sto include @@sql_mod query support * Allow zero (in) date when setting up internal _vt schema * modify test sto include @@sql_mod query support * Fix test failures * Fix failing tests. Minor refactor * change sql_mode t omost permissive (empty) * setPermissiveSQLMode * fixes per review * Add missing mock query --------- Signed-off-by: Shlomi Noach <[email protected]> Signed-off-by: Rohit Nayak <[email protected]> Co-authored-by: Shlomi Noach <[email protected]> Co-authored-by: Rohit Nayak <[email protected]>
* Add release notes summary for support views Signed-off-by: Florent Poinsard <[email protected]> * add link to the documentation Signed-off-by: Florent Poinsard <[email protected]> * simplify views release notes Signed-off-by: Florent Poinsard <[email protected]> --------- Signed-off-by: Florent Poinsard <[email protected]>
…#12415) * Examples: correct VTAdmin discovery file path and add check Signed-off-by: Matt Lord <[email protected]> * Remove jq dependency Signed-off-by: Matt Lord <[email protected]> * vtadmin examples scripts hardcode localhost Signed-off-by: Matt Lord <[email protected]> * Fix errant expectation Signed-off-by: Matt Lord <[email protected]> * Adjust healthy shard indicator Signed-off-by: Matt Lord <[email protected]> --------- Signed-off-by: Matt Lord <[email protected]>
This is needed to better support importing from MariaDB into Vitess/MySQL. Signed-off-by: Matt Lord <[email protected]>
…vitessio#12421) * Changed getSchemaRPC to return CreateView instead of SelectStmt Signed-off-by: Florent Poinsard <[email protected]> * test: fix expectation Signed-off-by: Harshit Gangal <[email protected]> --------- Signed-off-by: Florent Poinsard <[email protected]> Signed-off-by: Harshit Gangal <[email protected]> Co-authored-by: Harshit Gangal <[email protected]>
* restrict views to single keyspace Signed-off-by: Harshit Gangal <[email protected]> * feat: also create/alter and drop views on MySQL for information-schema-support Signed-off-by: Manan Gupta <[email protected]> * feat: do the DMLs for alter and create of view in a transaction so that they can be rolled back in case of MySQL failure Signed-off-by: Manan Gupta <[email protected]> * ignore view changes by schema tracker in vttablet when views are enabled Signed-off-by: Harshit Gangal <[email protected]> * test: fix test expectation Signed-off-by: Harshit Gangal <[email protected]> * Correct syntax error in defer func of E2E test Signed-off-by: Florent Poinsard <[email protected]> --------- Signed-off-by: Harshit Gangal <[email protected]> Signed-off-by: Manan Gupta <[email protected]> Signed-off-by: Florent Poinsard <[email protected]> Co-authored-by: Manan Gupta <[email protected]> Co-authored-by: Florent Poinsard <[email protected]>
…ssio#12426) * TableFilter: fix excluded RE listing Signed-off-by: Shlomi Noach <[email protected]> * extract GCTableNameExpression Signed-off-by: Shlomi Noach <[email protected]> * VReplication: exclude GC tables when reading schema Signed-off-by: Shlomi Noach <[email protected]> * wrap schema analyzis errors for better tracability Signed-off-by: Shlomi Noach <[email protected]> * resolve conflict Signed-off-by: Shlomi Noach <[email protected]> * (re)Formalize SQLError in VReplication, add underlying wrap/unwrap functionality Signed-off-by: Shlomi Noach <[email protected]> * update test to match new UnwrapAll() behavior Signed-off-by: Shlomi Noach <[email protected]> * do not unwrap Signed-off-by: Shlomi Noach <[email protected]> * Online DDL: use LastError for retrying vreplication streams Signed-off-by: Shlomi Noach <[email protected]> * differentiate between a temrinally failed workflow and one which 'has error' and can be retried Signed-off-by: Shlomi Noach <[email protected]> * wording Signed-off-by: Shlomi Noach <[email protected]> * simplified hasError() Signed-off-by: Shlomi Noach <[email protected]> * more onlineddl_vrepl tests; use dynamic throttler config; fix wait for vreplication status Signed-off-by: Shlomi Noach <[email protected]> --------- Signed-off-by: Shlomi Noach <[email protected]>
* examples: should use mysql80 property for vitess image Signed-off-by: deepthi <[email protected]> * Use MySQL80 in all examples/operator YAML files Signed-off-by: Florent Poinsard <[email protected]> * feat: fix vtadmin image version Signed-off-by: Manan Gupta <[email protected]> * feat: update release script to update vtadmin image version too Signed-off-by: Manan Gupta <[email protected]> * feat: fix vtop example script to use vtctldclient instead Signed-off-by: Manan Gupta <[email protected]> --------- Signed-off-by: deepthi <[email protected]> Signed-off-by: Florent Poinsard <[email protected]> Signed-off-by: Manan Gupta <[email protected]> Co-authored-by: Florent Poinsard <[email protected]> Co-authored-by: Manan Gupta <[email protected]>
…es (vitessio#12436) * schemadiff: AlterTableAlgorithmStratgy Signed-off-by: Shlomi Noach <[email protected]> Signed-off-by: Rohit Nayak <[email protected]> * minor rename Signed-off-by: Shlomi Noach <[email protected]> Signed-off-by: Rohit Nayak <[email protected]> * Use COPY algorithm while altering sidecardb tables Signed-off-by: Rohit Nayak <[email protected]> --------- Signed-off-by: Shlomi Noach <[email protected]> Signed-off-by: Rohit Nayak <[email protected]> Co-authored-by: Shlomi Noach <[email protected]>
Dependabot does pick up these go.mod files but somehow fails to open PRs for them to update things that are vulnerable. So doing it manually here. Signed-off-by: Dirkjan Bussink <[email protected]> Co-authored-by: Dirkjan Bussink <[email protected]>
…ssio#12328) (vitessio#12431) * Don't fail on schema init errors Signed-off-by: Rohit Nayak <[email protected]> * Fix debug var attribute name Signed-off-by: Rohit Nayak <[email protected]> * Fix typo in debug var Signed-off-by: Rohit Nayak <[email protected]> * Address review comment Signed-off-by: Rohit Nayak <[email protected]> * Address review comments Signed-off-by: Rohit Nayak <[email protected]> --------- Signed-off-by: Rohit Nayak <[email protected]> Co-authored-by: Rohit Nayak <[email protected]>
…NF rewrites (vitessio#14560) (vitessio#14574) Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com> Co-authored-by: Florent Poinsard <[email protected]>
…itessio#14586) (vitessio#14590) Signed-off-by: Harshit Gangal <[email protected]> Signed-off-by: Dirkjan Bussink <[email protected]> Co-authored-by: Harshit Gangal <[email protected]> Co-authored-by: Dirkjan Bussink <[email protected]>
…h `WAIT_FOR_EXECUTED_GTID_SET` (vitessio#14612) (vitessio#14620) Signed-off-by: Shlomi Noach <[email protected]>
…o release-16.0-github Signed-off-by: Arthur Schreiber <[email protected]>
Signed-off-by: Arthur Schreiber <[email protected]>
[Backport] Expose the `--tablet_types_to_wait` flag in `vtcombo`.
hmaurer
requested review from
deepthi,
harshit-gangal,
mattlord,
ajm188,
notfelineit,
frouioui,
rohit-nayak-ps,
GuptaManan100,
systay,
shlomi-noach,
arthurschreiber,
vmg,
derekperkins and
dkhenry
as code owners
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
vitess-bot
bot
added
NeedsBackportReason
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.