-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix aliasing in routes that have a derived table #15550
Conversation
Signed-off-by: Manan Gupta <[email protected]>
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
Signed-off-by: Manan Gupta <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice find and fix! 👍
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #15550 +/- ##
==========================================
+ Coverage 65.73% 65.75% +0.02%
==========================================
Files 1560 1560
Lines 194590 194592 +2
==========================================
+ Hits 127910 127955 +45
+ Misses 66680 66637 -43 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Manan Gupta <[email protected]>
Signed-off-by: Manan Gupta <[email protected]>
…) (#15554) Signed-off-by: Manan Gupta <[email protected]> Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>
…) (#15553) Signed-off-by: Manan Gupta <[email protected]> Signed-off-by: Matt Lord <[email protected]> Co-authored-by: Manan Gupta <[email protected]> Co-authored-by: Matt Lord <[email protected]>
…) (#15552) Signed-off-by: Manan Gupta <[email protected]> Co-authored-by: Manan Gupta <[email protected]>
Description
This PR fixes the aliasing in the final query that we produce for routes that have derived tables. Specifically it fixes the bug specified in #15549
Related Issue(s)
Checklist
Deployment Notes