Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix aliasing in queries by keeping required projections #15943

Merged
merged 2 commits into from
May 15, 2024

Conversation

GuptaManan100
Copy link
Member

@GuptaManan100 GuptaManan100 commented May 15, 2024

Description

This PR fixes the issue pointed out in #15944.

The problem was that we were removing some Projection operators that were only passing through the columns in the same order that they were receiving in. However, they were changing the column aliases. These projections are still required and should not be removed.

Related Issue(s)

Checklist

  • "Backport to:" labels have been added if this change should be back-ported to release branches
  • If this change is to be back-ported to previous releases, a justification is included in the PR description
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on CI?
  • Documentation was added or is not required

Deployment Notes

Copy link
Contributor

vitess-bot bot commented May 15, 2024

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels May 15, 2024
@github-actions github-actions bot added this to the v20.0.0 milestone May 15, 2024
@GuptaManan100 GuptaManan100 changed the title feat: remove code that removed necessary projections Fix aliasing in queries by keeping required projections May 15, 2024
Copy link

codecov bot commented May 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.43%. Comparing base (8639de2) to head (d9190c3).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #15943      +/-   ##
==========================================
+ Coverage   68.41%   68.43%   +0.02%     
==========================================
  Files        1562     1562              
  Lines      197056   197052       -4     
==========================================
+ Hits       134807   134850      +43     
+ Misses      62249    62202      -47     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@GuptaManan100 GuptaManan100 added Type: Bug Component: Query Serving and removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels May 15, 2024
@systay systay marked this pull request as ready for review May 15, 2024 08:15
@systay systay merged commit 951f273 into vitessio:main May 15, 2024
93 checks passed
@systay systay deleted the fix-alias-join branch May 15, 2024 09:12
@deepthi
Copy link
Member

deepthi commented May 15, 2024

Is this a bug that only exists on main aka v20? Are any back ports needed?

@GrahamCampbell
Copy link
Contributor

I have replicated this bug on V19.

@systay
Copy link
Collaborator

systay commented May 15, 2024

We need to backport this all the way to V17

@GuptaManan100
Copy link
Member Author

I checked at it doesn't help to back port this change to any of the releases. It is actually correct in the other releases. We introduced the capability to change the column names in simple projection in #15384, before that removing the simple projection if it was only passing through the columns was actually correct.
Even if we back port this change, the query doesn't work. I'm closing all the other PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug Report: Incorrect column name in a derived query
5 participants