New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rpc: retrieve unresolved transactions #16355

Closed

harshit-gangal wants to merge 2 commits into vitessio:main from planetscale:tx-resolver

go/vt/proto/query/query.pb.go

Large diffs are not rendered by default.

go/vt/proto/query/query_vtproto.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

go/vt/vttablet/tabletserver/health_streamer.go

-Original file line number
+Diff line change
@@ Expand Up / @@ -74,6 +74,7 @@ type healthStreamer struct { @@
     	// isServingPrimary stores if this tablet is currently the serving primary or not.
     	isServingPrimary bool
+    	te      *TxEngine
     	se      *schema.Engine
     	history *history.History
@@ Expand Down @@

go/vt/vttablet/tabletserver/tx_engine.go

-Original file line number
+Diff line change
@@ Expand Up / @@ -30,7 +30,7 @@ @@
     	"vitess.io/vitess/go/vt/log"
     	"vitess.io/vitess/go/vt/servenv"
     	"vitess.io/vitess/go/vt/vterrors"
     	"vitess.io/vitess/go/vt/vtgate/vtgateconn"
     	"vitess.io/vitess/go/vt/vttablet/tabletserver/connpool"
     	"vitess.io/vitess/go/vt/vttablet/tabletserver/tabletenv"
     	"vitess.io/vitess/go/vt/vttablet/tabletserver/tx"
@@ Expand Down Expand Up / @@ -480,20 +480,12 @@ @@
     			return
     		}
-    		coordConn, err := vtgateconn.Dial(ctx, te.coordinatorAddress)
-    		if err != nil {
-    			te.env.Stats().InternalErrors.Add("WatchdogFail", 1)
-    			log.Errorf("Error connecting to coordinator '%v': %v", te.coordinatorAddress, err)
-    			return
-    		}
-    		defer coordConn.Close()
     		var wg sync.WaitGroup
     		for tx := range txs {
     			wg.Add(1)
     			go func(dtid string) {
     				defer wg.Done()
     				if err := coordConn.ResolveTransaction(ctx, dtid); err != nil {
     					te.env.Stats().InternalErrors.Add("WatchdogFail", 1)
     					log.Errorf("Error notifying for dtid %s: %v", dtid, err)
     				}
@@ Expand Down @@

proto/query.proto

-Original file line number
+Diff line change
@@ Expand Up / @@ -886,6 +886,8 @@ message RealtimeStats { @@
       // udfs_changed is used to signal that the UDFs have changed on the tablet.
       bool udfs_changed = 9;
+      bool dt_unresolved = 10;
     }
     // AggregateStats contains information about the health of a group of
@@ Expand Down @@

web/vtadmin/src/proto/vtadmin.d.ts

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

web/vtadmin/src/proto/vtadmin.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

rpc: retrieve unresolved transactions #16355

rpc: retrieve unresolved transactions #16355

Diff view

Diff view

There are no files selected for viewing

GitHub Actions / Local example using zk2 on ubuntu-22.04

GitHub Actions / Local example using etcd on ubuntu-22.04

GitHub Actions / Region Sharding example using etcd on ubuntu-22.04

GitHub Actions / Local example using consul on ubuntu-22.04

GitHub Actions / Run endtoend tests on Cluster (backup_pitr)

GitHub Actions / Run endtoend tests on Cluster (onlineddl_vrepl_stress)

GitHub Actions / Run endtoend tests on Cluster (vtgate_transaction)

GitHub Actions / Run endtoend tests on Cluster (ers_prs_newfeatures_heavy)

GitHub Actions / Run endtoend tests on Cluster (vreplication_basic)

GitHub Actions / End-to-End Test

GitHub Actions / Run endtoend tests on Cluster (vtgate_queries)

GitHub Actions / Run endtoend tests on Cluster (topo_connection_cache)

GitHub Actions / Run endtoend tests on Cluster (onlineddl_vrepl)

GitHub Actions / Run endtoend tests on Cluster (vtgate_vschema)

GitHub Actions / Run endtoend tests on Cluster (vtgate_concurrentdml)

GitHub Actions / End-to-End Test (Race)

GitHub Actions / Run endtoend tests on Cluster (vtbackup)

GitHub Actions / Run endtoend tests on Cluster (15)

GitHub Actions / Run endtoend tests on Cluster (onlineddl_vrepl_stress_suite)

GitHub Actions / Run endtoend tests on Cluster (schemadiff_vrepl)

GitHub Actions / Run endtoend tests on Cluster (vreplication_migrate_vdiff2_convert_tz)

GitHub Actions / Run endtoend tests on Cluster (vtgate_godriver)

GitHub Actions / Run endtoend tests on Cluster (vreplication_multi_tenant)

GitHub Actions / Run endtoend tests on Cluster (mysql80)

GitHub Actions / Run endtoend tests on Cluster (vreplication_copy_parallel)

GitHub Actions / Run endtoend tests on Cluster (vtgate_reservedconn)

GitHub Actions / Run endtoend tests on Cluster (vtgate_general_heavy)

GitHub Actions / Unit Test (Race)

GitHub Actions / Run endtoend tests on Cluster (vtgate_schema_tracker)

GitHub Actions / Run endtoend tests on Cluster (onlineddl_vrepl_suite)

GitHub Actions / Run endtoend tests on Cluster (vtgate_partial_keyspace)

GitHub Actions / Run endtoend tests on Cluster (vtgate_topo_consul)

GitHub Actions / Unit Test (Evalengine_Race)

GitHub Actions / Run endtoend tests on Cluster (vtorc)

GitHub Actions / Run endtoend tests on Cluster (18)

GitHub Actions / Run endtoend tests on Cluster (vtgate_vindex_heavy)

GitHub Actions / Run Upgrade Downgrade Test - Query Serving (Schema)

GitHub Actions / Run endtoend tests on Cluster (vreplication_foreign_key_stress)

GitHub Actions / Run endtoend tests on Cluster (vtgate_gen4)

GitHub Actions / Run endtoend tests on Cluster (vtgate_schema)

GitHub Actions / Run endtoend tests on Cluster (vttablet_prscomplex)

GitHub Actions / Run endtoend tests on Cluster (vreplication_v2)

GitHub Actions / Run Upgrade Downgrade Test - Backups - Manual

GitHub Actions / Run Upgrade Downgrade Test - Reparent Old Vtctl

GitHub Actions / Run endtoend tests on Cluster (vtgate_topo)

GitHub Actions / Run endtoend tests on Cluster (vtctlbackup_sharded_clustertest_heavy)

GitHub Actions / Run endtoend tests on Cluster (vtgate_unsharded)

GitHub Actions / Run endtoend tests on Cluster (onlineddl_scheduler)

GitHub Actions / Code Coverage

GitHub Actions / Run endtoend tests on Cluster (tabletmanager_throttler_topo)

GitHub Actions / Run endtoend tests on Cluster (vreplication_mariadb_to_mysql)

GitHub Actions / Run endtoend tests on Cluster (12)

GitHub Actions / Run Upgrade Downgrade Test - Query Serving (Queries)

GitHub Actions / Run endtoend tests on Cluster (vtgate_topo_etcd)

GitHub Actions / Run endtoend tests on Cluster (21)

GitHub Actions / Run endtoend tests on Cluster (vreplication_partial_movetables_and_materialize)

GitHub Actions / Run endtoend tests on Cluster (vtgate_readafterwrite)

GitHub Actions / Run endtoend tests on Cluster (tabletmanager_tablegc)

GitHub Actions / Run endtoend tests on Cluster (xb_backup)

GitHub Actions / Run endtoend tests on Cluster (13)

GitHub Actions / Run endtoend tests on Cluster (onlineddl_revert)

GitHub Actions / Run Upgrade Downgrade Test - Backups - E2E

GitHub Actions / Run endtoend tests on Cluster (vtgate_foreignkey_stress)

GitHub Actions / Run endtoend tests on Cluster (vtgate_tablet_healthcheck_cache)

GitHub Actions / Run endtoend tests on Cluster (vreplication_cellalias)

GitHub Actions / Run endtoend tests on Cluster (vstream)

GitHub Actions / Docker Test Cluster 10

GitHub Actions / Docker Test Cluster 10

GitHub Actions / Run endtoend tests on Cluster (xb_recovery)

GitHub Actions / Run endtoend tests on Cluster (mysql_server_vault)

GitHub Actions / Run Upgrade Downgrade Test - Online DDL flow

GitHub Actions / Run endtoend tests on Cluster (backup_pitr_xtrabackup)

GitHub Actions / Run endtoend tests on Vitess Tester (vtgate)

GitHub Actions / Run endtoend tests on Cluster (tabletmanager_consul)

GitHub Actions / Run Upgrade Downgrade Test - Reparent Old VTTablet