Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Query to read transaction state #16431

Merged
merged 6 commits into from
Jul 24, 2024

Conversation

GuptaManan100
Copy link
Member

@GuptaManan100 GuptaManan100 commented Jul 19, 2024

Description

This PR adds a query that can be used to read the transaction state of an ongoing 2PC transaction.
Syntax:
show transaction status for <dtid>

> show transaction status for <dtid>;
+-------------+---------+-------------------------------+-------------------+
| id          | state   | record_time                   | participants      |
+-------------+---------+-------------------------------+-------------------+
| ks:-80:4334 | PREPARE | 2024-07-06 04:05:34 +0000 UTC | ks:80-a0,ks:a0-c0 |
+-------------+---------+-------------------------------+-------------------+
1 row in set (0.00 sec)

If the transaction ID is does not exists or already resolved, empty result set will be returned.

Related Issue(s)

Checklist

  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on CI?
  • Documentation was added or is not required

Copy link
Contributor

vitess-bot bot commented Jul 19, 2024

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@GuptaManan100 GuptaManan100 requested a review from ajm188 as a code owner July 19, 2024 07:51
@vitess-bot vitess-bot bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Jul 19, 2024
@GuptaManan100 GuptaManan100 removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels Jul 19, 2024
@github-actions github-actions bot added this to the v21.0.0 milestone Jul 19, 2024
Copy link

codecov bot commented Jul 19, 2024

Codecov Report

Attention: Patch coverage is 61.25000% with 31 lines in your changes missing coverage. Please review.

Project coverage is 68.66%. Comparing base (ae7214d) to head (6ef7992).

Files Patch % Lines
go/vt/vtgate/engine/transaction_status.go 71.69% 15 Missing ⚠️
go/vt/vtgate/tx_conn.go 45.45% 6 Missing ⚠️
go/vt/sqlparser/ast.go 0.00% 4 Missing ⚠️
go/vt/sqlparser/ast_format.go 0.00% 2 Missing ⚠️
go/vt/vtgate/executor.go 0.00% 2 Missing ⚠️
go/vt/vtgate/vcursor_impl.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #16431      +/-   ##
==========================================
+ Coverage   68.64%   68.66%   +0.02%     
==========================================
  Files        1549     1550       +1     
  Lines      199214   199285      +71     
==========================================
+ Hits       136750   136844      +94     
+ Misses      62464    62441      -23     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@GuptaManan100 GuptaManan100 force-pushed the read-transaction-query branch from 91f812d to dfdad62 Compare July 23, 2024 10:27
Signed-off-by: Harshit Gangal <[email protected]>
Signed-off-by: Harshit Gangal <[email protected]>
@harshit-gangal harshit-gangal removed the request for review from arthurschreiber July 23, 2024 15:00
@harshit-gangal harshit-gangal added Type: Feature and removed Type: Enhancement Logical improvement (somewhere between a bug and feature) labels Jul 23, 2024
@harshit-gangal harshit-gangal force-pushed the read-transaction-query branch from d3bafd8 to f56d8f5 Compare July 23, 2024 16:02
Signed-off-by: Harshit Gangal <[email protected]>
@GuptaManan100 GuptaManan100 merged commit 8ff313f into vitessio:main Jul 24, 2024
127 checks passed
@GuptaManan100 GuptaManan100 deleted the read-transaction-query branch July 24, 2024 04:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants