-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Query to read transaction state #16431
Merged
GuptaManan100
merged 6 commits into
vitessio:main
from
planetscale:read-transaction-query
Jul 24, 2024
Merged
Query to read transaction state #16431
GuptaManan100
merged 6 commits into
vitessio:main
from
planetscale:read-transaction-query
Jul 24, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuptaManan100
added
Type: Enhancement
Logical improvement (somewhere between a bug and feature)
Component: Query Serving
labels
Jul 19, 2024
GuptaManan100
requested review from
frouioui,
rohit-nayak-ps,
deepthi,
mattlord,
harshit-gangal,
systay,
shlomi-noach,
timvaillancourt and
arthurschreiber
as code owners
July 19, 2024 07:51
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
vitess-bot
bot
added
NeedsBackportReason
If backport labels have been applied to a PR, a justification is required
NeedsDescriptionUpdate
The description is not clear or comprehensive enough, and needs work
NeedsIssue
A linked issue is missing for this Pull Request
NeedsWebsiteDocsUpdate
What it says
labels
Jul 19, 2024
GuptaManan100
removed
NeedsDescriptionUpdate
The description is not clear or comprehensive enough, and needs work
NeedsWebsiteDocsUpdate
What it says
NeedsIssue
A linked issue is missing for this Pull Request
NeedsBackportReason
If backport labels have been applied to a PR, a justification is required
labels
Jul 19, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #16431 +/- ##
==========================================
+ Coverage 68.64% 68.66% +0.02%
==========================================
Files 1549 1550 +1
Lines 199214 199285 +71
==========================================
+ Hits 136750 136844 +94
+ Misses 62464 62441 -23 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Manan Gupta <[email protected]>
Signed-off-by: Manan Gupta <[email protected]>
Signed-off-by: Manan Gupta <[email protected]>
GuptaManan100
force-pushed
the
read-transaction-query
branch
from
July 23, 2024 10:27
91f812d
to
dfdad62
Compare
Signed-off-by: Harshit Gangal <[email protected]>
Signed-off-by: Harshit Gangal <[email protected]>
harshit-gangal
removed request for
mattlord,
shlomi-noach,
timvaillancourt,
ajm188 and
rohit-nayak-ps
July 23, 2024 15:00
harshit-gangal
added
Type: Feature
and removed
Type: Enhancement
Logical improvement (somewhere between a bug and feature)
labels
Jul 23, 2024
harshit-gangal
force-pushed
the
read-transaction-query
branch
from
July 23, 2024 16:02
d3bafd8
to
f56d8f5
Compare
harshit-gangal
approved these changes
Jul 23, 2024
systay
reviewed
Jul 23, 2024
systay
reviewed
Jul 23, 2024
systay
approved these changes
Jul 23, 2024
Signed-off-by: Harshit Gangal <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a query that can be used to read the transaction state of an ongoing 2PC transaction.
Syntax:
show transaction status for <dtid>
If the transaction ID is does not exists or already resolved, empty result set will be returned.
Related Issue(s)
Checklist