-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move tables with atomic transactions #16676
Merged
harshit-gangal
merged 6 commits into
vitessio:main
from
planetscale:move-tables-with-atomic-transactions
Sep 3, 2024
Merged
Move tables with atomic transactions #16676
harshit-gangal
merged 6 commits into
vitessio:main
from
planetscale:move-tables-with-atomic-transactions
Sep 3, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
vitess-bot
bot
added
NeedsBackportReason
If backport labels have been applied to a PR, a justification is required
NeedsDescriptionUpdate
The description is not clear or comprehensive enough, and needs work
NeedsIssue
A linked issue is missing for this Pull Request
NeedsWebsiteDocsUpdate
What it says
labels
Aug 28, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #16676 +/- ##
==========================================
+ Coverage 68.91% 68.95% +0.03%
==========================================
Files 1564 1565 +1
Lines 201337 201556 +219
==========================================
+ Hits 138759 138974 +215
- Misses 62578 62582 +4 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Manan Gupta <[email protected]>
GuptaManan100
force-pushed
the
move-tables-with-atomic-transactions
branch
from
August 29, 2024 04:15
073ad7c
to
07dee3c
Compare
Signed-off-by: Manan Gupta <[email protected]>
Signed-off-by: Manan Gupta <[email protected]>
Signed-off-by: Manan Gupta <[email protected]>
GuptaManan100
added
Component: Query Serving
Type: Testing
and removed
NeedsDescriptionUpdate
The description is not clear or comprehensive enough, and needs work
NeedsWebsiteDocsUpdate
What it says
NeedsIssue
A linked issue is missing for this Pull Request
NeedsBackportReason
If backport labels have been applied to a PR, a justification is required
labels
Aug 30, 2024
Signed-off-by: Manan Gupta <[email protected]>
…nlineddl queries to see the status Signed-off-by: Manan Gupta <[email protected]>
GuptaManan100
requested review from
rohit-nayak-ps and
shlomi-noach
as code owners
September 2, 2024 10:53
systay
approved these changes
Sep 2, 2024
26 tasks
rohit-nayak-ps
approved these changes
Sep 3, 2024
harshit-gangal
approved these changes
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the test to verify
MoveTables
works with atomic transactions without any issues.This PR also adds a design doc detailing how everything is supposed to work.
Related Issue(s)
Checklist
Deployment Notes