-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multiple changes on Distributed Transaction user apis #16788
Conversation
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
Signed-off-by: Harshit Gangal <[email protected]>
cf195a5
to
22e731a
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #16788 +/- ##
==========================================
+ Coverage 69.52% 69.53% +0.01%
==========================================
Files 1568 1569 +1
Lines 202442 202492 +50
==========================================
+ Hits 140741 140804 +63
+ Misses 61701 61688 -13 ☔ View full report in Codecov by Sentry. |
…clude command Signed-off-by: Harshit Gangal <[email protected]>
…clude transaction Signed-off-by: Harshit Gangal <[email protected]>
Signed-off-by: Harshit Gangal <[email protected]>
Signed-off-by: Harshit Gangal <[email protected]>
Signed-off-by: Harshit Gangal <[email protected]>
Signed-off-by: Harshit Gangal <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Signed-off-by: Harshit Gangal <[email protected]>
a2d689f
to
5cb7621
Compare
Signed-off-by: Harshit Gangal <[email protected]>
Signed-off-by: Harshit Gangal <[email protected]>
Signed-off-by: Harshit Gangal <[email protected]>
Description
This PR have mixed changes on distributed transaction.
Conclude
does not takeparticipants
list, only the grpc service have that option.Related Issue(s)
Checklist
Deployment Notes