make sure to send down timestamp queries to vttablet

[systay]

Description

The time zone system setting was not being fetched correctly, which lead to it being ignored when evaluating now().

Related Issue(s)

Fixes #16820

Checklist

• "Backport to:" labels have been added if this change should be back-ported to release branches
• If this change is to be back-ported to previous releases, a justification is included in the PR description
• Tests were added or are not required
• Did the new or modified tests pass consistently locally and on CI?
• Documentation was added or is not required

[vitess-bot]

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

• Ensure that the Pull Request has a descriptive title.
• Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

• Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

• Apply the release notes (needs details) label if users need to know about this change.
• New features should be documented.
• There should be some code comments as to why things are implemented the way they are.
• There should be a comment at the top of each new or modified test to explain what the test does.

New flags

• Is this flag really necessary?
• Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

• Each item in Jobs should be named in order to mark it as required.
• If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

• Protobuf changes should be wire-compatible.
• Changes to _vt tables and RPCs need to be backward compatible.
• RPC changes should be compatible with vitess-operator
• If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
• vtctl command output order should be stable and awk-able.

[GrahamCampbell]

Is it not incorrect to route these queries to a random shard? If someone runs:

START TRANSACTION;
SELECT * FROM `users` WHERE `id` = 1;
SELECT NOW();
COMMIT;

Where the users table is sharded on id, one might expect that the SELECT NOW() is run on the same machine as the SELECT FROM users, so that the transaction stays single-shard and so that NOW() returns the time at the start of the transaction, which is how unsharded MySQL works.

[codecov]

Codecov Report

Attention: Patch coverage is 85.71429% with 3 lines in your changes missing coverage. Please review.

Project coverage is 69.50%. Comparing base (538dd4c) to head (ca83068).
Report is 93 commits behind head on main.

Files with missing lines	Patch %	Lines
go/vt/vtgate/vcursor_impl.go	83.33%	3 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #16819      +/-   ##
==========================================
+ Coverage   68.98%   69.50%   +0.52%     
==========================================
  Files        1562     1568       +6     
  Lines      200690   202480    +1790     
==========================================
+ Hits       138449   140743    +2294     
+ Misses      62241    61737     -504     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[harshit-gangal]

Let's add a e2e test for it to validate the fix.

[systay]

Is it not incorrect to route these queries to a random shard? If someone runs:

START TRANSACTION;
SELECT * FROM `users` WHERE `id` = 1;
SELECT NOW();
COMMIT;

Where the users table is sharded on id, one might expect that the SELECT NOW() is run on the same machine as the SELECT FROM users, so that the transaction stays single-shard and so that NOW() returns the time at the start of the transaction, which is how unsharded MySQL works.

Good point. I'll update the PR and try again.

[systay]

Replaced by #16824