Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making Reshard work smoothly with Atomic Transactions #16844

Merged
merged 10 commits into from
Oct 3, 2024

feat: address review comments

85c1c34
Select commit
Loading
Failed to load commit list.
Merged

Making Reshard work smoothly with Atomic Transactions #16844

feat: address review comments
85c1c34
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Oct 3, 2024 in 0s

69.43% (-0.01%) compared to 766bc64, passed because coverage increased by 0% when compared to adjusted base (69.43%)

View this Pull Request on Codecov

69.43% (-0.01%) compared to 766bc64, passed because coverage increased by 0% when compared to adjusted base (69.43%)

Details

Codecov Report

Attention: Patch coverage is 67.74194% with 20 lines in your changes missing coverage. Please review.

Project coverage is 69.43%. Comparing base (766bc64) to head (85c1c34).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
go/vt/vttablet/tabletserver/tabletserver.go 20.00% 12 Missing ⚠️
go/vt/vttablet/tabletmanager/rpc_replication.go 0.00% 3 Missing ⚠️
go/vt/vttablet/tabletmanager/tm_init.go 57.14% 3 Missing ⚠️
go/vt/vttablet/tabletmanager/tm_state.go 86.66% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #16844      +/-   ##
==========================================
- Coverage   69.43%   69.43%   -0.01%     
==========================================
  Files        1571     1571              
  Lines      203086   203239     +153     
==========================================
+ Hits       141013   141113     +100     
- Misses      62073    62126      +53     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.