Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add blurb about experimental 8.4 support #16886

Merged
merged 2 commits into from
Oct 6, 2024
Merged

Add blurb about experimental 8.4 support #16886

merged 2 commits into from
Oct 6, 2024

Conversation

dbussink
Copy link
Contributor

@dbussink dbussink commented Oct 3, 2024

MySQL 8.4 passes the test suites, but it's otherwise not yet tested. This should be good enough then to mark it as experimentally supported to ask community feedback and hopefully more people test it out.

Related Issue(s)

Part of #16466

Checklist

  • "Backport to:" labels have been added if this change should be back-ported to release branches
  • If this change is to be back-ported to previous releases, a justification is included in the PR description
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on CI?
  • Documentation was added or is not required

@dbussink dbussink requested a review from deepthi as a code owner October 3, 2024 09:21
@vitess-bot vitess-bot
Copy link
Contributor

vitess-bot bot commented Oct 3, 2024

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Oct 3, 2024
@dbussink dbussink added Type: Documentation Component: Documentation docs related issues/PRs and removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels Oct 3, 2024
@github-actions github-actions bot added this to the v21.0.0 milestone Oct 3, 2024
deepthi
deepthi reviewed Oct 3, 2024
View reviewed changes
Copy link
Member

@deepthi deepthi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to add a line to the Table of Contents at the top.

@deepthi deepthi changed the title Add blurp about experimental 8.4 support Add blurb about experimental 8.4 support Oct 3, 2024
@mattlord mattlord self-requested a review October 3, 2024 16:20
@rohit-nayak-ps rohit-nayak-ps mentioned this pull request Oct 4, 2024
Closed
57 tasks
@dbussink
Copy link
Contributor Author

dbussink commented Oct 4, 2024

You need to add a line to the Table of Contents at the top.

Done!

@dbussink
Add blurp about experimental 8.4 support
a92ef0a 
MySQL 8.4 passes the test suites, but it's otherwise not yet tested.
This should be good enough then to mark it as experimentally supported
to ask community feedback and hopefully more people test it out.

Signed-off-by: Dirkjan Bussink <[email protected]>
@dbussink
Add header for changelog
ebb3c45 
Signed-off-by: Dirkjan Bussink <[email protected]>
@dbussink dbussink force-pushed the dbussink/experimental-8-4-support branch from 345191f to ebb3c45 Compare October 4, 2024 18:51
mattlord
mattlord approved these changes Oct 4, 2024
View reviewed changes
Copy link
Contributor

@mattlord mattlord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I wonder if we should add similar language here? https://vitess.io/docs/21.0/overview/supported-databases/

@dbussink
Copy link
Contributor Author

dbussink commented Oct 5, 2024

Thanks! I wonder if we should add similar language here? https://vitess.io/docs/21.0/overview/supported-databases/

vitessio/website#1860

@rohit-nayak-ps rohit-nayak-ps merged commit 057687b into vitessio:main Oct 6, 2024
96 checks passed
@rohit-nayak-ps rohit-nayak-ps deleted the dbussink/experimental-8-4-support branch October 6, 2024 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deepthi deepthi deepthi left review comments

@rohit-nayak-ps rohit-nayak-ps rohit-nayak-ps approved these changes

@mattlord mattlord mattlord approved these changes

Assignees
No one assigned
Labels
Component: Documentation docs related issues/PRs Type: Documentation
Projects
None yet
Milestone
v21.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@dbussink @deepthi @mattlord @rohit-nayak-ps