-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remember all tablets in VTOrc #16888
Merged
GuptaManan100
merged 2 commits into
vitessio:main
from
planetscale:remember-drained-tablets
Oct 7, 2024
Merged
Remember all tablets in VTOrc #16888
GuptaManan100
merged 2 commits into
vitessio:main
from
planetscale:remember-drained-tablets
Oct 7, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Manan Gupta <[email protected]>
Signed-off-by: Manan Gupta <[email protected]>
GuptaManan100
requested review from
deepthi,
shlomi-noach and
timvaillancourt
as code owners
October 3, 2024 12:42
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
vitess-bot
bot
added
NeedsBackportReason
If backport labels have been applied to a PR, a justification is required
NeedsDescriptionUpdate
The description is not clear or comprehensive enough, and needs work
NeedsIssue
A linked issue is missing for this Pull Request
NeedsWebsiteDocsUpdate
What it says
labels
Oct 3, 2024
GuptaManan100
removed
NeedsDescriptionUpdate
The description is not clear or comprehensive enough, and needs work
NeedsWebsiteDocsUpdate
What it says
NeedsIssue
A linked issue is missing for this Pull Request
NeedsBackportReason
If backport labels have been applied to a PR, a justification is required
labels
Oct 3, 2024
deepthi
approved these changes
Oct 3, 2024
timvaillancourt
approved these changes
Oct 3, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #16888 +/- ##
==========================================
- Coverage 69.42% 69.42% -0.01%
==========================================
Files 1571 1571
Lines 203276 203276
==========================================
- Hits 141125 141121 -4
- Misses 62151 62155 +4 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the issue described in #16887. VTOrc now remembers all the tablets in its state, even if they aren't of a replica type. We just ensure not to run any repairs on them. This ensures that all the shard metrics that VTOrc publishes like
ErrantGTIDTabletCount
are correct since it is seeing the full picture and not a part of it.Related Issue(s)
Checklist
Deployment Notes