Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix golang upgrade workflow #16890

Merged
merged 1 commit into from
Oct 4, 2024
Merged

Fix golang upgrade workflow #16890

merged 1 commit into from
Oct 4, 2024

Conversation

frouioui
Copy link
Member

@frouioui frouioui commented Oct 3, 2024

Description

The go upgrade PR has not run in a few days since we changed the way we set up go in GHA. This PR fixes it.

@frouioui
Fix golang upgrade workflow
8e41d43 
Signed-off-by: Florent Poinsard <[email protected]>
@vitess-bot vitess-bot
Copy link
Contributor

vitess-bot bot commented Oct 3, 2024

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Oct 3, 2024
@frouioui frouioui added Type: Bug Component: Build/CI and removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels Oct 3, 2024
@github-actions github-actions bot added this to the v21.0.0 milestone Oct 3, 2024
timvaillancourt
timvaillancourt approved these changes Oct 3, 2024
View reviewed changes
Copy link
Contributor

@timvaillancourt timvaillancourt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My apologies @frouioui!

@frouioui
Copy link
Member Author

frouioui commented Oct 3, 2024

My apologies @frouioui!

No worries at all! I had not realized this while reviewing 🙏🏼

@timvaillancourt
Copy link
Contributor

My apologies @frouioui!

No worries at all! I had not realized this while reviewing 🙏🏼

Right, it's a bit hard to know with the CIs that only run on open or a schedule 👍

@deepthi deepthi merged commit edff3b9 into vitessio:main Oct 4, 2024
108 checks passed
@deepthi deepthi deleted the fix-go-upgrade-workflow branch October 4, 2024 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timvaillancourt timvaillancourt timvaillancourt approved these changes

@deepthi deepthi deepthi approved these changes

@mattlord mattlord Awaiting requested review from mattlord mattlord is a code owner

@rohit-nayak-ps rohit-nayak-ps Awaiting requested review from rohit-nayak-ps rohit-nayak-ps is a code owner

Assignees
No one assigned
Labels
Component: Build/CI Type: Bug
Projects
None yet
Milestone
v21.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@frouioui @timvaillancourt @deepthi