Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support settings changes with atomic transactions #16974

Merged

Conversation

GuptaManan100
Copy link
Member

@GuptaManan100 GuptaManan100 commented Oct 16, 2024

Description

This PR adds the support to store the settings changes that were made in an atomic transaction so that redoing them works with those settings.

Vitess handles SET <variable>=<value> commands in different ways based on the settings variable that is being set -

  • IgnoreThese - Some variables like big_tables are just ignored by Vitess.
  • NotSupported - Trying to set variables like binlog_row_image just fails.
  • ReadOnly - These variables like version can only be read and not updated.
  • CheckAndIgnore - These variables are ignored when tried to update.
  • VitessAware - These variables change vitess behaviour. Sometimes, they are stored in the session and also sent down to vttablets to be set on MySQL.
  • UseReservedConn - We don't use reserved connections any more (we use the settings pool), but settings here are sent down to vttablet and are applied on the connections.

Some of the settings can change how some of the DML queries interact. For example, the time_zone variable affects what we get from the NOW() function call. For settings of UseReservedConn type, that we apply on the connection of an atomic transaction, we need to keep track of them in our list of recorded queries, so that when we try to redo the transaction (incase of a failure), we don't end up changing the behaviour of the queries. This PR accomplishes this change.

Related Issue(s)

Checklist

  • "Backport to:" labels have been added if this change should be back-ported to release branches
  • If this change is to be back-ported to previous releases, a justification is included in the PR description
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on CI?
  • Documentation was added or is not required

Deployment Notes

Copy link
Contributor

vitess-bot bot commented Oct 16, 2024

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Oct 16, 2024
@GuptaManan100 GuptaManan100 removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels Oct 16, 2024
@github-actions github-actions bot added this to the v22.0.0 milestone Oct 16, 2024
Copy link

codecov bot commented Oct 16, 2024

Codecov Report

Attention: Patch coverage is 63.15789% with 14 lines in your changes missing coverage. Please review.

Project coverage is 69.33%. Comparing base (538dd4c) to head (333ce7e).
Report is 162 commits behind head on main.

Files with missing lines Patch % Lines
go/vt/vttablet/tabletserver/query_executor.go 37.50% 5 Missing ⚠️
go/vt/vttablet/sandboxconn/sandboxconn.go 73.33% 4 Missing ⚠️
go/vt/vttablet/tabletserver/stateful_connection.go 0.00% 3 Missing ⚠️
go/vt/vttablet/tabletserver/tx_engine.go 90.00% 1 Missing ⚠️
go/vt/vttablet/tabletserver/tx_pool.go 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #16974      +/-   ##
==========================================
+ Coverage   68.98%   69.33%   +0.35%     
==========================================
  Files        1562     1571       +9     
  Lines      200690   204208    +3518     
==========================================
+ Hits       138449   141596    +3147     
- Misses      62241    62612     +371     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@systay systay added the NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work label Oct 18, 2024
@GuptaManan100 GuptaManan100 removed the NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work label Oct 18, 2024
@harshit-gangal harshit-gangal merged commit e881b9f into vitessio:main Oct 18, 2024
99 of 100 checks passed
@harshit-gangal harshit-gangal deleted the settings-atomic-transactions branch October 18, 2024 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Query Serving Type: Enhancement Logical improvement (somewhere between a bug and feature)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants