Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Atomic Transaction StartCommit api to return the commit state #17116

Merged
merged 4 commits into from
Nov 8, 2024

Conversation

harshit-gangal
Copy link
Member

@harshit-gangal harshit-gangal commented Oct 30, 2024

Description

This PR adds StartCommit API state to the response from VTTablet.
This can be used by VTGate as Transaction Coordinator to take faster rollback decision.
There are 3 states:

  1. Unknown - Action: VTGate leave the transaction open for the transaction resolver to resolve it later
  2. Fail - Action: VTGate rollback the transaction in the RMs except in MM
  3. Success - Action: VTGate proceed with next steps of Distributed Transaction Commit Flow.

Related Issue(s)

Checklist

  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on CI?
  • Documentation was added or is not required

Copy link
Contributor

vitess-bot bot commented Oct 30, 2024

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Oct 30, 2024
@github-actions github-actions bot added this to the v22.0.0 milestone Oct 30, 2024
@harshit-gangal harshit-gangal added Type: Enhancement Logical improvement (somewhere between a bug and feature) Component: Query Serving and removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels Oct 30, 2024
Signed-off-by: Harshit Gangal <[email protected]>
…hen the failure is certain

Signed-off-by: Harshit Gangal <[email protected]>
Copy link

codecov bot commented Oct 30, 2024

Codecov Report

Attention: Patch coverage is 87.36842% with 12 lines in your changes missing coverage. Please review.

Project coverage is 67.17%. Comparing base (6ad9898) to head (cc8add3).
Report is 31 commits behind head on main.

Files with missing lines Patch % Lines
go/vt/vtcombo/tablet_map.go 0.00% 3 Missing ⚠️
go/vt/vttablet/tabletserver/dt_executor.go 66.66% 3 Missing ⚠️
go/vt/vttablet/grpctabletconn/conn.go 75.00% 2 Missing ⚠️
go/vt/vttablet/sandboxconn/sandboxconn.go 93.10% 2 Missing ⚠️
go/vt/vtexplain/vtexplain_vttablet.go 0.00% 1 Missing ⚠️
go/vt/vtgate/tx_conn.go 94.11% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #17116      +/-   ##
==========================================
+ Coverage   67.14%   67.17%   +0.03%     
==========================================
  Files        1571     1571              
  Lines      252093   252295     +202     
==========================================
+ Hits       169269   169484     +215     
+ Misses      82824    82811      -13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@GuptaManan100 GuptaManan100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@systay systay changed the title Atomic Transaction Startcommit api to return the commit state Atomic Transaction StartCommit api to return the commit state Nov 8, 2024
@systay systay merged commit 78f7db2 into vitessio:main Nov 8, 2024
101 checks passed
@systay systay deleted the startcommit-api branch November 8, 2024 15:23
rvrangel pushed a commit to rvrangel/vitess that referenced this pull request Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Query Serving Type: Enhancement Logical improvement (somewhere between a bug and feature)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants