Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Track shard session affecting change inside the transaction #17266

Merged
merged 7 commits into from
Dec 4, 2024

Conversation

harshit-gangal
Copy link
Member

@harshit-gangal harshit-gangal commented Nov 20, 2024

Description

This PR adds tracking on per shard transaction on VTGate Session to know if DMLs caused any modification in the underlying database.

This will be used to restrict the participants of cross shard transactions ignoring non-modified shards from the list.
As this is part of VTGate Session, it cannot be used in same release as it could potentially break VTGate upgrade

Related Issue(s)

Checklist

  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on CI?
  • Documentation was added or is not required

Copy link
Contributor

vitess-bot bot commented Nov 20, 2024

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Nov 20, 2024
@github-actions github-actions bot added this to the v22.0.0 milestone Nov 20, 2024
@harshit-gangal harshit-gangal added Type: Enhancement Logical improvement (somewhere between a bug and feature) Component: Query Serving and removed NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels Nov 20, 2024
@harshit-gangal harshit-gangal removed the NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work label Nov 21, 2024
Copy link

codecov bot commented Nov 21, 2024

Codecov Report

Attention: Patch coverage is 96.29630% with 4 lines in your changes missing coverage. Please review.

Project coverage is 67.42%. Comparing base (216fd70) to head (1d465bb).
Report is 36 commits behind head on main.

Files with missing lines Patch % Lines
go/vt/vtgate/safe_session.go 95.45% 3 Missing ⚠️
go/vt/vtgate/scatter_conn.go 97.61% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #17266      +/-   ##
==========================================
+ Coverage   67.39%   67.42%   +0.03%     
==========================================
  Files        1570     1574       +4     
  Lines      252917   253313     +396     
==========================================
+ Hits       170446   170795     +349     
- Misses      82471    82518      +47     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@harshit-gangal harshit-gangal marked this pull request as ready for review November 21, 2024 11:38
@@ -894,17 +901,24 @@ type shardActionInfo struct {
actionNeeded actionNeeded
reservedID, transactionID int64
alias *topodatapb.TabletAlias
ignoreOldSession bool
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't quite get why this ignoreOldSession field is required.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is for reserved connection, when they are rebuild, the old session instance held should be ignored
and a new shard session should append

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't we continue to use the reserveid and transaction id fields like we were using before?

Copy link
Collaborator

@systay systay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Harshit Gangal <[email protected]>
@harshit-gangal harshit-gangal merged commit 1cb39b0 into vitessio:main Dec 4, 2024
99 of 100 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Query Serving Type: Enhancement Logical improvement (somewhere between a bug and feature)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants