Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove binlog-server point in time recoveries code & tests #17361

Merged
merged 9 commits into from
Dec 19, 2024
Merged

Remove binlog-server point in time recoveries code & tests #17361

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
17be379
remove mention of 'ripple'
shlomi-noach Dec 10, 2024
d908287
Remove binlog server based PITR logic and tests
shlomi-noach Dec 10, 2024
c657409
resolved conflicts
shlomi-noach Dec 10, 2024
4343b7e
help output
shlomi-noach Dec 10, 2024
9722c14
Merge branch 'main' into cleanup-binlog-pitr
shlomi-noach Dec 10, 2024
b6f3250
removed rippled
shlomi-noach Dec 10, 2024
1c17d55
Merge branch 'main' into cleanup-binlog-pitr
shlomi-noach Dec 11, 2024
a9a72bc
ensure existence of EXTRA_BIN
shlomi-noach Dec 11, 2024
ae458a7
Using .keep file to ensure directory exists
shlomi-noach Dec 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion go/mysql/flavor_filepos.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ func (flv *filePosFlavor) gtidMode(c *Conn) (string, error) {

// serverUUID is part of the Flavor interface.
func (flv *filePosFlavor) serverUUID(c *Conn) (string, error) {
// keep @@global as lowercase, as some servers like the Ripple binlog server only honors a lowercase `global` value
// keep @@global as lowercase, as some servers like a binlog server only honors a lowercase `global` value
qr, err := c.ExecuteFetch("SELECT @@global.server_uuid", 1, false)
if err != nil {
return "", err
Expand Down
6 changes: 3 additions & 3 deletions go/mysql/flavor_mysql.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ var _ flavor = (*mysqlFlavor82)(nil)

// primaryGTIDSet is part of the Flavor interface.
func (mysqlFlavor) primaryGTIDSet(c *Conn) (replication.GTIDSet, error) {
// keep @@global as lowercase, as some servers like the Ripple binlog server only honors a lowercase `global` value
// keep @@global as lowercase, as some servers like a binlog server only honors a lowercase `global` value
qr, err := c.ExecuteFetch("SELECT @@global.gtid_executed", 1, false)
if err != nil {
return nil, err
Expand All @@ -73,7 +73,7 @@ func (mysqlFlavor) primaryGTIDSet(c *Conn) (replication.GTIDSet, error) {

// purgedGTIDSet is part of the Flavor interface.
func (mysqlFlavor) purgedGTIDSet(c *Conn) (replication.GTIDSet, error) {
// keep @@global as lowercase, as some servers like the Ripple binlog server only honors a lowercase `global` value
// keep @@global as lowercase, as some servers like a binlog server only honors a lowercase `global` value
qr, err := c.ExecuteFetch("SELECT @@global.gtid_purged", 1, false)
if err != nil {
return nil, err
Expand All @@ -86,7 +86,7 @@ func (mysqlFlavor) purgedGTIDSet(c *Conn) (replication.GTIDSet, error) {

// serverUUID is part of the Flavor interface.
func (mysqlFlavor) serverUUID(c *Conn) (string, error) {
// keep @@global as lowercase, as some servers like the Ripple binlog server only honors a lowercase `global` value
// keep @@global as lowercase, as some servers like a binlog server only honors a lowercase `global` value
qr, err := c.ExecuteFetch("SELECT @@global.server_uuid", 1, false)
if err != nil {
return "", err
Expand Down
137 changes: 0 additions & 137 deletions go/test/endtoend/recovery/pitr/binlog_server.go
View file
Open in desktop

This file was deleted.

Loading
Loading