Improved Compatibility Around LAST_INSERT_ID

[systay]

Description

This PR improves last_insert_id(x) behavior to align more closely with MySQL in various scenarios.

Key changes

1. New fetch_last_insert_id Field
   Introduced a boolean field, fetch_last_insert_id, in the ExecuteOptions proto.
   • When enabled, vttablet automatically runs a SELECT last_insert_id() query immediately after executing a query containing a last_insert_id(x) expression.
   • The planner automatically sets this flag upon detecting such expressions.
   • This is to work around a mysql bug.
2. sqltypes.Result Updates
   • Added a new field, InsertIDChanged.
   • This field signals that the session state must be updated with the new InsertID, even if the value is 0
3. Query Signature Enhancements:
   • Updated semantic checking to store relevant information in the query’s QuerySignature.
4. Improved LIMIT Behavior:
   • Enhanced LIMIT to ensure all input rows are received when expecting last_insert_id values.
   • As a result, in some scenarios, data retrieval from tablets cannot be stopped until all results are fetched.

More changes around this are coming.

Related Issue(s)

Fixes #17298

Checklist

• "Backport to:" labels have been added if this change should be back-ported to release branches
• If this change is to be back-ported to previous releases, a justification is included in the PR description
• Tests were added or are not required
• Did the new or modified tests pass consistently locally and on CI?
• Documentation was added or is not required

[vitess-bot]

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

• Ensure that the Pull Request has a descriptive title.
• Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

• Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

• Apply the release notes (needs details) label if users need to know about this change.
• New features should be documented.
• There should be some code comments as to why things are implemented the way they are.
• There should be a comment at the top of each new or modified test to explain what the test does.

New flags

• Is this flag really necessary?
• Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

• Each item in Jobs should be named in order to mark it as required.
• If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

• Protobuf changes should be wire-compatible.
• Changes to _vt tables and RPCs need to be backward compatible.
• RPC changes should be compatible with vitess-operator
• If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
• vtctl command output order should be stable and awk-able.

[codecov]

Codecov Report

Attention: Patch coverage is 77.93594% with 62 lines in your changes missing coverage. Please review.

Project coverage is 67.64%. Comparing base (9714713) to head (eb58df1).

Files with missing lines	Patch %	Lines
go/vt/vttablet/tabletserver/query_executor.go	49.39%	42 Missing ⚠️
go/vt/vtgate/executorcontext/vcursor_impl.go	62.50%	9 Missing ⚠️
go/vt/vtgate/engine/plan_description.go	0.00%	4 Missing ⚠️
go/vt/vtgate/engine/insert.go	60.00%	2 Missing ⚠️
go/vt/vtgate/scatter_conn.go	85.71%	2 Missing ⚠️
go/vt/vtgate/engine/lock.go	0.00%	1 Missing ⚠️
go/vt/vtgate/engine/unlock.go	0.00%	1 Missing ⚠️
go/vt/vtgate/engine/vexplain.go	0.00%	1 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff            @@
##             main   #17408    +/-   ##
========================================
  Coverage   67.63%   67.64%            
========================================
  Files        1581     1581            
  Lines      253860   254002   +142     
========================================
+ Hits       171708   171809   +101     
- Misses      82152    82193    +41     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[harshit-gangal]

Suggested change

	if opts != nil {
	opts.FetchLastInsertId = fetchLastInsertID
	} else if fetchLastInsertID {
	opts = &querypb.ExecuteOptions{FetchLastInsertId: fetchLastInsertID}
	}
	if opts == nil && fetchLastInsertID {
	opts = &querypb.ExecuteOptions{FetchLastInsertId: fetchLastInsertID}
	}

[harshit-gangal]

nit: could be outside the test block run method

[harshit-gangal]

looks good, left few comments