-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add vtctldclient missing cmds #17442
Draft
mattlord
wants to merge
14
commits into
vitessio:main
Choose a base branch
from
planetscale:vtctldclient_missing_cmds
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
+8,009
−4,760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matt Lord <[email protected]>
Signed-off-by: Matt Lord <[email protected]>
Signed-off-by: Matt Lord <[email protected]>
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
vitess-bot
bot
added
NeedsBackportReason
If backport labels have been applied to a PR, a justification is required
NeedsDescriptionUpdate
The description is not clear or comprehensive enough, and needs work
NeedsIssue
A linked issue is missing for this Pull Request
NeedsWebsiteDocsUpdate
What it says
labels
Dec 27, 2024
mattlord
added
Type: Internal Cleanup
Component: vtctldclient
and removed
NeedsBackportReason
If backport labels have been applied to a PR, a justification is required
labels
Dec 27, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #17442 +/- ##
==========================================
- Coverage 67.68% 67.59% -0.09%
==========================================
Files 1583 1585 +2
Lines 254321 254632 +311
==========================================
- Hits 172131 172126 -5
- Misses 82190 82506 +316 ☔ View full report in Codecov by Sentry. |
mattlord
force-pushed
the
vtctldclient_missing_cmds
branch
2 times, most recently
from
December 27, 2024 12:41
9824c10
to
ec59343
Compare
Signed-off-by: Matt Lord <[email protected]>
mattlord
force-pushed
the
vtctldclient_missing_cmds
branch
from
December 27, 2024 22:53
ec59343
to
851ccac
Compare
Signed-off-by: Matt Lord <[email protected]>
mattlord
force-pushed
the
vtctldclient_missing_cmds
branch
from
December 27, 2024 23:47
8c5f3e9
to
05c4c1d
Compare
Signed-off-by: Matt Lord <[email protected]>
5 tasks
mattlord
removed
NeedsDescriptionUpdate
The description is not clear or comprehensive enough, and needs work
NeedsWebsiteDocsUpdate
What it says
NeedsIssue
A linked issue is missing for this Pull Request
labels
Dec 28, 2024
dbussink
reviewed
Dec 30, 2024
mattlord
commented
Dec 30, 2024
mattlord
force-pushed
the
vtctldclient_missing_cmds
branch
2 times, most recently
from
January 1, 2025 21:13
3018fa3
to
4465813
Compare
This reverts commit a091042. Signed-off-by: Matt Lord <[email protected]>
Signed-off-by: Matt Lord <[email protected]>
Signed-off-by: Matt Lord <[email protected]>
Signed-off-by: Matt Lord <[email protected]>
Signed-off-by: Matt Lord <[email protected]>
Signed-off-by: Matt Lord <[email protected]>
Signed-off-by: Matt Lord <[email protected]>
Signed-off-by: Matt Lord <[email protected]>
mattlord
force-pushed
the
vtctldclient_missing_cmds
branch
from
January 1, 2025 23:41
a9136a0
to
f0047fa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This implements client commands in
vtctldclient
that were never ported during the client migration. These are things that were identified while moving all endtoend tests to usevtctldclient
exclusively in #17441. The missing commands being:We will (after merging in
main
once #17441 is merged) also then replace all remainingvtctlclient
usage in the e2e tests with usage of these newvtctldclient
commands.Related Issue(s)
Checklist