-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Benchmark Prepared statement and expected Improvement #17449
Draft
harshit-gangal
wants to merge
4
commits into
vitessio:main
Choose a base branch
from
planetscale:prepare-stmt
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+278
−80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Harshit Gangal <[email protected]>
Signed-off-by: Harshit Gangal <[email protected]>
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
vitess-bot
bot
added
NeedsBackportReason
If backport labels have been applied to a PR, a justification is required
NeedsDescriptionUpdate
The description is not clear or comprehensive enough, and needs work
NeedsIssue
A linked issue is missing for this Pull Request
NeedsWebsiteDocsUpdate
What it says
labels
Dec 30, 2024
harshit-gangal
added
Component: Query Serving
and removed
NeedsDescriptionUpdate
The description is not clear or comprehensive enough, and needs work
NeedsWebsiteDocsUpdate
What it says
NeedsIssue
A linked issue is missing for this Pull Request
NeedsBackportReason
If backport labels have been applied to a PR, a justification is required
labels
Dec 30, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #17449 +/- ##
==========================================
- Coverage 67.67% 67.66% -0.01%
==========================================
Files 1583 1584 +1
Lines 254363 254360 -3
==========================================
- Hits 172140 172118 -22
- Misses 82223 82242 +19 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Harshit Gangal <[email protected]>
harshit-gangal
force-pushed
the
prepare-stmt
branch
from
January 2, 2025 10:59
6eba850
to
e749db8
Compare
harshit-gangal
changed the title
Benchmark Prepared statement
Benchmark Prepared statement and expected Improvement
Jan 2, 2025
harshit-gangal
force-pushed
the
prepare-stmt
branch
from
January 2, 2025 12:04
7ff72d5
to
8c74592
Compare
Signed-off-by: Harshit Gangal <[email protected]>
harshit-gangal
force-pushed
the
prepare-stmt
branch
from
January 2, 2025 12:58
8c74592
to
b948875
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added a benchmark test for prepared statements covering insert, select, update, and delete operations. Utilized this test to analyze heap allocations, revealing that approximately 20% of allocations are consumed in generating a query plan, which can be avoided during prepared statement execution.
Implemented an optimization to bypass query parsing and normalization for already-prepared statements. Benchmark results demonstrated significant query execution performance gains:
The overall geometric mean improvement in query execution across all operations was 4.94%, with potential for further gains as query size increases.
Related Issue(s)
Checklist