Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Benchmark Prepared statement and expected Improvement #17449

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

harshit-gangal
Copy link
Member

@harshit-gangal harshit-gangal commented Dec 30, 2024

Description

Added a benchmark test for prepared statements covering insert, select, update, and delete operations. Utilized this test to analyze heap allocations, revealing that approximately 20% of allocations are consumed in generating a query plan, which can be avoided during prepared statement execution.

image

goos: darwin
goarch: arm64
pkg: vitess.io/vitess/go/test/endtoend/preparestmt
cpu: Apple M1 Max
                      │ /Users/planetscale/benchmark/prepare-no-change.txt │
                      │                       sec/op                       │
PreparedStmt/Insert-4                                          490.9µ ± 2%
PreparedStmt/Select-4                                          305.8µ ± 0%
PreparedStmt/Update-4                                          342.2µ ± 2%
PreparedStmt/Delete-4                                          311.3µ ± 1%
geomean                                                        355.6µ

Implemented an optimization to bypass query parsing and normalization for already-prepared statements. Benchmark results demonstrated significant query execution performance gains:

  • 6.40% improvement in query execution time for basic select queries
  • 9.08% improvement in query execution time for join-based select queries
  • 3.62% improvement in query execution time for delete queries
  • No statistically significant change in query execution time for insert and update queries

The overall geometric mean improvement in query execution across all operations was 4.94%, with potential for further gains as query size increases.

goos: darwin
goarch: arm64
pkg: vitess.io/vitess/go/test/endtoend/preparestmt
cpu: Apple M1 Max
                                        │ nochange-2s-v3.txt │         prepared-2s-v3.txt         │
                                        │       sec/op       │    sec/op     vs base              │
PreparedStmt/Insert-8                            506.5µ ± 9%   490.1µ ± 14%       ~ (p=0.065 n=6)
PreparedStmt/Select-8                            306.7µ ± 5%   287.1µ ±  5%  -6.40% (p=0.002 n=6)
PreparedStmt/Join_Select:Simple_Route-8          300.5µ ± 4%   273.3µ ±  3%  -9.08% (p=0.002 n=6)
PreparedStmt/Update-8                            351.0µ ± 5%   343.2µ ±  3%       ~ (p=0.240 n=6)
PreparedStmt/Delete-8                            318.9µ ± 4%   307.3µ ±  4%  -3.62% (p=0.015 n=6)
geomean                                          349.6µ        332.4µ        -4.94%

Related Issue(s)

Checklist

  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on CI?
  • Documentation was added or is not required

Copy link
Contributor

vitess-bot bot commented Dec 30, 2024

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Dec 30, 2024
@harshit-gangal harshit-gangal added Component: Query Serving and removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels Dec 30, 2024
@github-actions github-actions bot added this to the v22.0.0 milestone Dec 30, 2024
Copy link

codecov bot commented Dec 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.66%. Comparing base (9383943) to head (b948875).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #17449      +/-   ##
==========================================
- Coverage   67.67%   67.66%   -0.01%     
==========================================
  Files        1583     1584       +1     
  Lines      254363   254360       -3     
==========================================
- Hits       172140   172118      -22     
- Misses      82223    82242      +19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Harshit Gangal <[email protected]>
@harshit-gangal harshit-gangal changed the title Benchmark Prepared statement Benchmark Prepared statement and expected Improvement Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant