-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-19.0] Fix week number for date_format evalengine function (#17432) #17454
Merged
dbussink
merged 2 commits into
vitessio:release-19.0
from
planetscale:release-19.0-backport-evalengine-fix
Dec 30, 2024
Merged
[release-19.0] Fix week number for date_format evalengine function (#17432) #17454
dbussink
merged 2 commits into
vitessio:release-19.0
from
planetscale:release-19.0-backport-evalengine-fix
Dec 30, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbussink
added
Type: Bug
Backport
This is a backport
Component: Evalengine
changes to the evaluation engine
labels
Dec 30, 2024
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
dbussink
requested review from
harshit-gangal,
mattlord,
ajm188,
notfelineit,
GuptaManan100,
frouioui,
rohit-nayak-ps,
shlomi-noach,
derekperkins,
systay,
timvaillancourt,
arthurschreiber and
vmg
as code owners
December 30, 2024 11:02
Signed-off-by: Dirkjan Bussink <[email protected]>
dbussink
force-pushed
the
release-19.0-backport-evalengine-fix
branch
from
December 30, 2024 11:03
ab49463
to
d2fa319
Compare
GuptaManan100
approved these changes
Dec 30, 2024
dbussink
changed the title
Release 19.0 backport evalengine fix
[release-19.0] Fix week number for date_format evalengine function (#17432)
Dec 30, 2024
rohit-nayak-ps
approved these changes
Dec 30, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-19.0 #17454 +/- ##
================================================
+ Coverage 65.12% 65.14% +0.01%
================================================
Files 1560 1560
Lines 238322 238316 -6
================================================
+ Hits 155218 155255 +37
+ Misses 83104 83061 -43 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Manan Gupta <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #17432 to fix CI
Related Issue(s)
Fix from #17432
Checklist