-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(reporters): rewrite dot
reporter without log-update
#6943
fix(reporters): rewrite dot
reporter without log-update
#6943
Conversation
dot
renderer without log-update
dot
reporter without log-update
✅ Deploy Preview for vitest-dev ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
967104c
to
d7a87a0
Compare
@vitest/browser
@vitest/coverage-istanbul
@vitest/mocker
@vitest/expect
@vitest/pretty-format
@vitest/coverage-v8
@vitest/runner
@vitest/snapshot
@vitest/spy
@vitest/ui
@vitest/utils
vite-node
vitest
@vitest/web-worker
@vitest/ws-client
commit: |
82e32e9
to
287433e
Compare
287433e
to
1eb3bfb
Compare
async onWatcherRerun(files: string[], trigger?: string) { | ||
await this.stopListRender() | ||
super.onWatcherRerun(files, trigger) | ||
onTestFilePrepare(file: File): void { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just noticed we are still using the old API here... We need to experiment with the new one to see what's missing. Otherwise, it will never be out of the experimental
I don't know if we should do it here, but keep in mind that it needs to be rewritten before 2.2 (I can do it myself, if no one has resources)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You mean the File
part, as in we should use state.getReportedEntity
instead?
When building the summary reporter I had at first that one in use and also some new Reporter API hooks. But as nothing was working well I started to reduce amount of changes. First fix all reporter flickering and scrolling issues and then look into new APIs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, the File
part. Everything else looks nice 👍🏻
Description
log-update
hidesprocess.stdout
calls that come outside Vitest, e.g. NodeJS deprecation warnings. This is visible for example in Vite repo'stest-serve
command.log-update
got confused of row count and started to duplicate rowsDotSummary
'sonTestFileFinished
that optimizes this.log-update
fromdot
reporter.Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
pnpm-lock.yaml
unless you introduce a new test example.Tests
pnpm test:ci
.Documentation
pnpm run docs
command.Changesets
feat:
,fix:
,perf:
,docs:
, orchore:
.