Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(browser): fix matchers.d.ts #6995

Merged
merged 9 commits into from
Dec 1, 2024

Conversation

hi-ogawa
Copy link
Contributor

@hi-ogawa hi-ogawa commented Dec 1, 2024

Description

While checking the repro for #6989, I spotted another red squiggles:

image

It looks like we can catch this issue by tsc without skipLibCheck, so I added test/dts-playwright for this:

$ pnpm -C test/dts-playwright test

> @vitest/test-dts-fixture@ test /home/hiroshi/code/others/vitest/test/dts-playwright
> tsc -b

../../packages/browser/matchers.d.ts:20:66 - error TS2304: Cannot find name 'ExpectPollOptions'.

20     element: <T extends Element | Locator>(element: T, options?: ExpectPollOptions) => PromisifyDomAssertion<Awaited<Element | null>>
                                                                    ~~~~~~~~~~~~~~~~~


Found 1 error.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

Copy link

netlify bot commented Dec 1, 2024

Deploy Preview for vitest-dev ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 974686e
🔍 Latest deploy log https://app.netlify.com/sites/vitest-dev/deploys/674c24d04008e9000804c819
😎 Deploy Preview https://deploy-preview-6995--vitest-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@hi-ogawa hi-ogawa marked this pull request as ready for review December 1, 2024 09:19
@sheremet-va sheremet-va merged commit a485b32 into vitest-dev:main Dec 1, 2024
17 checks passed
@hi-ogawa hi-ogawa deleted the fix-browser-dts branch December 2, 2024 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants