[Bugfix, Feature] Not emitting empty color #516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit prevents an empty color to be emitted on the 3rd line.
With this, if the specified default color
-C ""is empty, the script will not emit anything on the third line of the output. Hence, i3blocks will use the default color that is specified in the i3blocks settings.The benefit of this is, that One does not need to specify the color in the i3blocks settings, but can use the settings from the i3config, which get passed to i3blocks.
This is useful for me because I switch between light and dark themes during the day, and use different i3configs for that. Now just setting
-C ""will use whatever color is set for the time of the day.