upgrade to bevy 0.12 #221
Merged
upgrade to bevy 0.12 #221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Bevy 0.12 was just released! |
|
yea, cargo updated |
frewsxcv
approved these changes
Nov 4, 2023
paul-hansen
reviewed
Nov 4, 2023
src/lib.rs
Outdated
| @@ -144,7 +144,7 @@ fn compare_descriptors(a: &ImageSampler, b: &ImageSampler) -> bool { | |||
| match (a, b) { | |||
| (ImageSampler::Default, ImageSampler::Default) => true, | |||
| (ImageSampler::Descriptor(descriptor_a), ImageSampler::Descriptor(descriptor_b)) => { | |||
| descriptor_a == descriptor_b | |||
| descriptor_a.label == descriptor_b.label | |||
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
There was a problem hiding this comment.
compared all of them
msklosak
reviewed
Nov 5, 2023
Co-authored-by: Matthew S. Klosak <[email protected]>
ManevilleF
reviewed
Nov 5, 2023
|
@raffaeleragni thanks a lot for the PR! There are a few CI warnings, but I'll take it from here. (I'll push directly to your branch, I hope you won't mind.) |
|
no prob |
Schmarni-Dev
pushed a commit
to Schmarni-Dev/bevy_egui
that referenced
this pull request
Dec 23, 2023
* upgrade to bevy 0.12 * upgrade * bevy release * Update src/lib.rs Co-authored-by: Matthew S. Klosak <[email protected]> * compare all fields * use real time * Simplify the compare_descriptors implementation * Fix compiling in WASM * Fix formatting * Fix web-sys version just in the CI instead * Remove redundant dev-dependencies features --------- Co-authored-by: Matthew S. Klosak <[email protected]> Co-authored-by: mvlabat <[email protected]>
Schmarni-Dev
pushed a commit
to Schmarni-Dev/bevy_egui
that referenced
this pull request
Dec 23, 2023
* upgrade to bevy 0.12 * upgrade * bevy release * Update src/lib.rs Co-authored-by: Matthew S. Klosak <[email protected]> * compare all fields * use real time * Simplify the compare_descriptors implementation * Fix compiling in WASM * Fix formatting * Fix web-sys version just in the CI instead * Remove redundant dev-dependencies features --------- Co-authored-by: Matthew S. Klosak <[email protected]> Co-authored-by: mvlabat <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to update cargo when bevy 0.12 is out