Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to egui 0.25.0 #248

Closed
wants to merge 1 commit into from
Closed

Conversation

MickHarrigan
Copy link

The only major thing of note here is in src/systems.rs where a new Key field is introduced that takes both the key that is pressed and a physical key that allows non-qwerty users to still use the same layout.

I don't know if this should be used out of the gate yet or if there should be more thought before it gets utilized. Wouldn't mind any input on this.

@MickHarrigan MickHarrigan changed the title Updated to egui 0.25.0 Update to egui 0.25.0 Jan 9, 2024
@MickHarrigan MickHarrigan marked this pull request as draft January 9, 2024 18:11
@MickHarrigan
Copy link
Author

MickHarrigan commented Jan 9, 2024

Converted this to a draft as with some further digging the PRs in both bevy_input and egui that updated the winit crate to 0.29 have a bit more nuance to them that this change should take note of. I will continue to read through their changes and see what is the best course of action soon.

Edit: after reading through both the changes it seems that the winit changes have yet to come through on the bevy side so the logical key wouldn't be properly reflected yet. Thus I believe that the change that I already made should be good until bevy releases a new version that uses the winit updates.

If I missed something or you disagree feel free to reach out about it.

@Vrixyz
Copy link
Contributor

Vrixyz commented Feb 3, 2024

Now with bevyengine/bevy#11400 ; from KeyboardInput, we can now use key_code for physical key, and logical_key for logical key.

@xangelix
Copy link

xangelix commented Feb 5, 2024

https://github.com/emilk/egui/releases/tag/0.26.0 is also now available.

@vladbat00
Copy link
Owner

Egui 0.26 is now in main, thanks for the PR!

@vladbat00 vladbat00 closed this Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants