Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better error on Web when missing web_sys_unstable_apis #270

Merged
merged 2 commits into from
Mar 28, 2024
Merged

Better error on Web when missing web_sys_unstable_apis #270

merged 2 commits into from
Mar 28, 2024

Conversation

Vrixyz
Copy link
Contributor

@Vrixyz Vrixyz commented Mar 27, 2024 •
edited
Loading

Before:

image

After:

image

This was referenced Mar 27, 2024
Closed
Merged
@Vrixyz
Copy link
Contributor Author

Vrixyz commented Mar 27, 2024 •
edited
Loading

Not 100% sure if include_str! is working as-is when publishing, or if it's good practice to add a folder for the errors, but I think it looks better than the alternative which doubles the error message in a less readable fashion:

image

@Vrixyz Vrixyz force-pushed the 269-better-error-web-sys-unstable branch from 7063851 to eb57930 Compare March 27, 2024 22:26
@vladbat00 vladbat00 mentioned this pull request Mar 28, 2024
Merged
@vladbat00 vladbat00 merged commit fdd6e2c into vladbat00:main Mar 28, 2024
39 checks passed
@vladbat00
Copy link
Owner

Awesome, thanks!

@luca-della-vedova luca-della-vedova mentioned this pull request Jul 25, 2024
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Vrixyz @vladbat00